[PATCH] hyper-v: Fix wakeup from suspend-to-idle

Subsystems: hid core layer, hyper-v/azure core and drivers, input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE2841d

6 messages, 4 authors, 2018-11-06 · open the first message on its own page

[PATCH] hyper-v: Fix wakeup from suspend-to-idle

From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: 2018-09-12 16:11:07 

It makes little sense but still possible to put Hyper-V guests into
suspend-to-idle state. To wake them up two wakeup sources were registered
in the past: hyperv-keyboard and hid-hyperv. However, since
commit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups from
suspend-to-idle") pm_wakeup_event() from these devices is ignored. Switch
to pm_wakeup_hard_event() API as these devices are actually the only
possible way to wakeup Hyper-V guests.

Fixes: eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle)
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hid/hid-hyperv.c              | 2 +-
 drivers/input/serio/hyperv-keyboard.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index b372854cf38d..704049e62d58 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -309,7 +309,7 @@ static void mousevsc_on_receive(struct hv_device *device,
 		hid_input_report(input_dev->hid_device, HID_INPUT_REPORT,
 				 input_dev->input_buf, len, 1);
 
-		pm_wakeup_event(&input_dev->device->device, 0);
+		pm_wakeup_hard_event(&input_dev->device->device);
 
 		break;
 	default:
diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c
index 47a0e81a2989..a8b9be3e28db 100644
--- a/drivers/input/serio/hyperv-keyboard.c
+++ b/drivers/input/serio/hyperv-keyboard.c
@@ -177,7 +177,7 @@ static void hv_kbd_on_receive(struct hv_device *hv_dev,
 		 * state because the Enter-UP can trigger a wakeup at once.
 		 */
 		if (!(info & IS_BREAK))
-			pm_wakeup_event(&hv_dev->device, 0);
+			pm_wakeup_hard_event(&hv_dev->device);
 
 		break;
 
-- 
2.14.4

Re: [PATCH] hyper-v: Fix wakeup from suspend-to-idle

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2018-09-13 06:55:38 

On Wed, Sep 12, 2018 at 6:11 PM Vitaly Kuznetsov [off-list ref] wrote:
It makes little sense but still possible to put Hyper-V guests into
suspend-to-idle state. To wake them up two wakeup sources were registered
in the past: hyperv-keyboard and hid-hyperv. However, since
commit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups from
suspend-to-idle") pm_wakeup_event() from these devices is ignored. Switch
to pm_wakeup_hard_event() API as these devices are actually the only
possible way to wakeup Hyper-V guests.

Fixes: eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle)
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Rafael J. Wysocki <redacted>
quoted hunk
---
 drivers/hid/hid-hyperv.c              | 2 +-
 drivers/input/serio/hyperv-keyboard.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index b372854cf38d..704049e62d58 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -309,7 +309,7 @@ static void mousevsc_on_receive(struct hv_device *device,
                hid_input_report(input_dev->hid_device, HID_INPUT_REPORT,
                                 input_dev->input_buf, len, 1);

-               pm_wakeup_event(&input_dev->device->device, 0);
+               pm_wakeup_hard_event(&input_dev->device->device);

                break;
        default:
diff --git a/drivers/input/serio/hyperv-keyboard.c b/drivers/input/serio/hyperv-keyboard.c
index 47a0e81a2989..a8b9be3e28db 100644
--- a/drivers/input/serio/hyperv-keyboard.c
+++ b/drivers/input/serio/hyperv-keyboard.c
@@ -177,7 +177,7 @@ static void hv_kbd_on_receive(struct hv_device *hv_dev,
                 * state because the Enter-UP can trigger a wakeup at once.
                 */
                if (!(info & IS_BREAK))
-                       pm_wakeup_event(&hv_dev->device, 0);
+                       pm_wakeup_hard_event(&hv_dev->device);

                break;

--
2.14.4

RE: [PATCH] hyper-v: Fix wakeup from suspend-to-idle

From: KY Srinivasan <kys@microsoft.com>
Date: 2018-09-13 12:58:09 

-----Original Message-----
From: Rafael J. Wysocki <rafael@kernel.org>
Sent: Wednesday, September 12, 2018 11:55 PM
To: vkuznets <vkuznets@redhat.com>
Cc: Linux PM <redacted>; Rafael J. Wysocki
[off-list ref]; KY Srinivasan [off-list ref]; Haiyang Zhang
[off-list ref]; Stephen Hemminger
[off-list ref]; Jiri Kosina [off-list ref]; Dmitry
Torokhov [off-list ref]; linux-input@vger.kernel.org;
Linux Kernel Mailing List [off-list ref]
Subject: Re: [PATCH] hyper-v: Fix wakeup from suspend-to-idle

On Wed, Sep 12, 2018 at 6:11 PM Vitaly Kuznetsov [off-list ref]
wrote:
quoted
It makes little sense but still possible to put Hyper-V guests into
suspend-to-idle state. To wake them up two wakeup sources were
registered
quoted
in the past: hyperv-keyboard and hid-hyperv. However, since
commit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups from
suspend-to-idle") pm_wakeup_event() from these devices is ignored.
Switch
quoted
to pm_wakeup_hard_event() API as these devices are actually the only
possible way to wakeup Hyper-V guests.

Fixes: eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from
suspend-to-idle)
quoted
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Rafael J. Wysocki <redacted>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>

quoted
---
 drivers/hid/hid-hyperv.c              | 2 +-
 drivers/input/serio/hyperv-keyboard.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index b372854cf38d..704049e62d58 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -309,7 +309,7 @@ static void mousevsc_on_receive(struct hv_device
*device,
quoted
                hid_input_report(input_dev->hid_device, HID_INPUT_REPORT,
                                 input_dev->input_buf, len, 1);

-               pm_wakeup_event(&input_dev->device->device, 0);
+               pm_wakeup_hard_event(&input_dev->device->device);

                break;
        default:
diff --git a/drivers/input/serio/hyperv-keyboard.c
b/drivers/input/serio/hyperv-keyboard.c
quoted
index 47a0e81a2989..a8b9be3e28db 100644
--- a/drivers/input/serio/hyperv-keyboard.c
+++ b/drivers/input/serio/hyperv-keyboard.c
@@ -177,7 +177,7 @@ static void hv_kbd_on_receive(struct hv_device
*hv_dev,
quoted
                 * state because the Enter-UP can trigger a wakeup at once.
                 */
                if (!(info & IS_BREAK))
-                       pm_wakeup_event(&hv_dev->device, 0);
+                       pm_wakeup_hard_event(&hv_dev->device);

                break;

--
2.14.4





  

    
Re: [PATCH] hyper-v: Fix wakeup from suspend-to-idle

    

      From: Jiri Kosina <jikos@kernel.org>

      Date: 2018-09-24 09:24:17 
    

  

  
On Wed, 12 Sep 2018, Vitaly Kuznetsov wrote:

It makes little sense but still possible to put Hyper-V guests into
suspend-to-idle state. To wake them up two wakeup sources were registered
in the past: hyperv-keyboard and hid-hyperv. However, since
commit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups from
suspend-to-idle") pm_wakeup_event() from these devices is ignored. Switch
to pm_wakeup_hard_event() API as these devices are actually the only
possible way to wakeup Hyper-V guests.

Fixes: eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle)
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hid/hid-hyperv.c              | 2 +-
	Acked-by: Jiri Kosina [off-list ref]

for the above. I guess this'd better go through ACPI tree?

Thanks,

-- 
Jiri Kosina
SUSE Labs





  

    
Re: [PATCH] hyper-v: Fix wakeup from suspend-to-idle

    

      From: "Rafael J. Wysocki" <rafael@kernel.org>

      Date: 2018-09-24 22:49:29 
    

  

  
On Mon, Sep 24, 2018 at 11:24 AM Jiri Kosina [off-list ref] wrote:
On Wed, 12 Sep 2018, Vitaly Kuznetsov wrote:

quoted
It makes little sense but still possible to put Hyper-V guests into
suspend-to-idle state. To wake them up two wakeup sources were registered
in the past: hyperv-keyboard and hid-hyperv. However, since
commit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups from
suspend-to-idle") pm_wakeup_event() from these devices is ignored. Switch
to pm_wakeup_hard_event() API as these devices are actually the only
possible way to wakeup Hyper-V guests.

Fixes: eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle)
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hid/hid-hyperv.c              | 2 +-
        Acked-by: Jiri Kosina [off-list ref]

for the above. I guess this'd better go through ACPI tree?
No problem with that if you prefer.

Cheers,
Rafael





  

    
Re: [PATCH] hyper-v: Fix wakeup from suspend-to-idle

    

      From: Vitaly Kuznetsov <vkuznets@redhat.com>

      Date: 2018-11-06 17:07:10 
    

  

  
"Rafael J. Wysocki" [off-list ref] writes:

On Mon, Sep 24, 2018 at 11:24 AM Jiri Kosina [off-list ref] wrote:
quoted
On Wed, 12 Sep 2018, Vitaly Kuznetsov wrote:

quoted
It makes little sense but still possible to put Hyper-V guests into
suspend-to-idle state. To wake them up two wakeup sources were registered
in the past: hyperv-keyboard and hid-hyperv. However, since
commit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups from
suspend-to-idle") pm_wakeup_event() from these devices is ignored. Switch
to pm_wakeup_hard_event() API as these devices are actually the only
possible way to wakeup Hyper-V guests.

Fixes: eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle)
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hid/hid-hyperv.c              | 2 +-
        Acked-by: Jiri Kosina [off-list ref]

for the above. I guess this'd better go through ACPI tree?
No problem with that if you prefer.
It seems this patch got lost somewhere :-( 

-- 
Vitaly




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help