[PATCH] input: sun4i-lradc: Convert to using %pOFn instead of device_node.name

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, sun4i low res adc attached tablet keys driver, the rest

STALE2872d

3 messages, 2 authors, 2018-09-28 · open the first message on its own page

[PATCH] input: sun4i-lradc: Convert to using %pOFn instead of device_node.name

From: Rob Herring <robh@kernel.org>
Date: 2018-08-28 01:54:52

In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Cc: Hans de Goede <redacted>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Maxime Ripard <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/input/keyboard/sun4i-lradc-keys.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
index a37c172452e6..57272df34cd5 100644
--- a/drivers/input/keyboard/sun4i-lradc-keys.c
+++ b/drivers/input/keyboard/sun4i-lradc-keys.c
@@ -185,19 +185,19 @@ static int sun4i_lradc_load_dt_keymap(struct device *dev,
 
 		error = of_property_read_u32(pp, "channel", &channel);
 		if (error || channel != 0) {
-			dev_err(dev, "%s: Inval channel prop\n", pp->name);
+			dev_err(dev, "%pOFn: Inval channel prop\n", pp);
 			return -EINVAL;
 		}
 
 		error = of_property_read_u32(pp, "voltage", &map->voltage);
 		if (error) {
-			dev_err(dev, "%s: Inval voltage prop\n", pp->name);
+			dev_err(dev, "%pOFn: Inval voltage prop\n", pp);
 			return -EINVAL;
 		}
 
 		error = of_property_read_u32(pp, "linux,code", &map->keycode);
 		if (error) {
-			dev_err(dev, "%s: Inval linux,code prop\n", pp->name);
+			dev_err(dev, "%pOFn: Inval linux,code prop\n", pp);
 			return -EINVAL;
 		}
 
-- 
2.17.1

Re: [PATCH] input: sun4i-lradc: Convert to using %pOFn instead of device_node.name

From: Rob Herring <robh@kernel.org>
Date: 2018-09-28 21:54:56

On Mon, Aug 27, 2018 at 8:54 PM Rob Herring [off-list ref] wrote:
In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Cc: Hans de Goede <redacted>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Maxime Ripard <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/input/keyboard/sun4i-lradc-keys.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Ping.
quoted hunk
diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
index a37c172452e6..57272df34cd5 100644
--- a/drivers/input/keyboard/sun4i-lradc-keys.c
+++ b/drivers/input/keyboard/sun4i-lradc-keys.c
@@ -185,19 +185,19 @@ static int sun4i_lradc_load_dt_keymap(struct device *dev,

                error = of_property_read_u32(pp, "channel", &channel);
                if (error || channel != 0) {
-                       dev_err(dev, "%s: Inval channel prop\n", pp->name);
+                       dev_err(dev, "%pOFn: Inval channel prop\n", pp);
                        return -EINVAL;
                }

                error = of_property_read_u32(pp, "voltage", &map->voltage);
                if (error) {
-                       dev_err(dev, "%s: Inval voltage prop\n", pp->name);
+                       dev_err(dev, "%pOFn: Inval voltage prop\n", pp);
                        return -EINVAL;
                }

                error = of_property_read_u32(pp, "linux,code", &map->keycode);
                if (error) {
-                       dev_err(dev, "%s: Inval linux,code prop\n", pp->name);
+                       dev_err(dev, "%pOFn: Inval linux,code prop\n", pp);
                        return -EINVAL;
                }

--
2.17.1

Re: [PATCH] input: sun4i-lradc: Convert to using %pOFn instead of device_node.name

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2018-09-28 23:59:24

On Mon, Aug 27, 2018 at 08:52:24PM -0500, Rob Herring wrote:
In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Cc: Hans de Goede <redacted>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Maxime Ripard <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Applied, thank you.
quoted hunk
---
 drivers/input/keyboard/sun4i-lradc-keys.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
index a37c172452e6..57272df34cd5 100644
--- a/drivers/input/keyboard/sun4i-lradc-keys.c
+++ b/drivers/input/keyboard/sun4i-lradc-keys.c
@@ -185,19 +185,19 @@ static int sun4i_lradc_load_dt_keymap(struct device *dev,
 
 		error = of_property_read_u32(pp, "channel", &channel);
 		if (error || channel != 0) {
-			dev_err(dev, "%s: Inval channel prop\n", pp->name);
+			dev_err(dev, "%pOFn: Inval channel prop\n", pp);
 			return -EINVAL;
 		}
 
 		error = of_property_read_u32(pp, "voltage", &map->voltage);
 		if (error) {
-			dev_err(dev, "%s: Inval voltage prop\n", pp->name);
+			dev_err(dev, "%pOFn: Inval voltage prop\n", pp);
 			return -EINVAL;
 		}
 
 		error = of_property_read_u32(pp, "linux,code", &map->keycode);
 		if (error) {
-			dev_err(dev, "%s: Inval linux,code prop\n", pp->name);
+			dev_err(dev, "%pOFn: Inval linux,code prop\n", pp);
 			return -EINVAL;
 		}
 
-- 
2.17.1
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help