# Re: \[PATCH 5/6\] mtd: rawnand: ams-delta: use GPIO lookup table

- From: Andy Shevchenko \<hidden\>
- Date: 2018-05-18 21:21:19 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2018/05/5287796
- Thread: https://ratatoskr.run/linux-arm-kernel/2018/05/5287779/t.md

```text
On Sat, May 19, 2018 at 12:09 AM, Janusz Krzysztofik
[ref] wrote:

> +       gpiod_rdy = devm_gpiod_get_optional(&pdev->dev, "rdy", GPIOD_IN);
> +       if (!IS_ERR_OR_NULL(gpiod_rdy)) {

So, is it optional or not at the end?
If it is, why do we check for NULL?

>                 this->dev_ready = ams_delta_nand_ready;
>         } else {
>                 this->dev_ready = NULL;
>                 pr_notice("Couldn't request gpio for Delta NAND ready.\n");

dev_notice() ?

>         }

> +err_gpiod:
> +       if (err == -ENODEV || err == -ENOENT)
> +               err = -EPROBE_DEFER;

Hmm...

-- 
With Best Regards,
Andy Shevchenko
```