# \[PATCH\] Input: pxa27x\_keypad: Delete an error message for a failed memory allocation

- From: SF Markus Elfring \<hidden\>
- Date: 2018-01-25 21:20:13 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2018/01/5190835
- Thread: https://ratatoskr.run/linux-input/2018/01/5190835/t.md

```text
From: Markus Elfring <redacted>
Date: Thu, 25 Jan 2018 22:15:27 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/input/keyboard/pxa27x_keypad.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
index d0bdaeadf86d..bafd075344e2 100644
--- a/drivers/input/keyboard/pxa27x_keypad.c
+++ b/drivers/input/keyboard/pxa27x_keypad.c
@@ -290,10 +290,8 @@ static int pxa27x_keypad_build_keycode_from_dt(struct pxa27x_keypad *keypad)
 	int error;
 
 	pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
-	if (!pdata) {
-		dev_err(dev, "failed to allocate memory for pdata\n");
+	if (!pdata)
 		return -ENOMEM;
-	}
 
 	error = pxa27x_keypad_matrix_key_parse_dt(keypad, pdata);
 	if (error) {
-- 
2.16.1

```
