# \[PATCH 2/2\] Input: wm831x-on: Improve a size determination in wm831x\_on\_probe() - From: SF Markus Elfring \ - Date: 2018-01-24 21:22:43 - List: linux-input - Page: https://ratatoskr.run/linux-input/2018/01/5190331 - Thread: https://ratatoskr.run/linux-input/2018/01/5190327/t.md ```text From: Markus Elfring Date: Wed, 24 Jan 2018 21:58:42 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/misc/wm831x-on.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c index 06f5c4857a0c..0d8f7a11f63d 100644 --- a/drivers/input/misc/wm831x-on.c +++ b/drivers/input/misc/wm831x-on.c @@ -75,8 +75,7 @@ static int wm831x_on_probe(struct platform_device *pdev) int irq = wm831x_irq(wm831x, platform_get_irq(pdev, 0)); int ret; - wm831x_on = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_on), - GFP_KERNEL); + wm831x_on = devm_kzalloc(&pdev->dev, sizeof(*wm831x_on), GFP_KERNEL); if (!wm831x_on) return -ENOMEM; -- 2.16.1 ```