Thread (4 messages) 4 messages, 2 authors, 2017-11-14

Re: Support for additional properties in touchscreen.h

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-11-14 18:09:35

On Tue, Nov 14, 2017 at 08:55:01AM +0100, Gregor Riepl wrote:
quoted
The fuzz (smoothing the output coordinates) is done in input core and
the touchscreen properties parsing code already handles
touchscreen-fuzz-x and touchscreen-fuzz-y parameters. The only thing
that is needed is to pass these parameters through DT or ACPI or
static properties, based on particular device.
Thanks for the clarification, Dmitry.

So do I understand correctly that it would suffice to add these parameters to
a DMI match in drivers/platform/x86/silead_dmi.c ?

Something like:

static const struct property_entry my_imaginary_tablet_props[] = {
	PROPERTY_ENTRY_U32("touchscreen-size-x", 1920),
	PROPERTY_ENTRY_U32("touchscreen-size-y", 1080),
	PROPERTY_ENTRY_U32("touchscreen-fuzz-x", 10),
	PROPERTY_ENTRY_U32("touchscreen-fuzz-y", 10),
	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-my-imaginary-tablet.fw"),
	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
	{ }
};
Yes, and you'd need to add a new entry to silead_ts_dmi_table.

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help