Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support

Charles Keepax [off-list ref] writes:

On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote:

quoted

Add support for the new ac97 bus model, where devices are automatically
discovered on AC-Links.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
Since v4:
 - added #ifdef spotted by Charles
---
 	snd_soc_codec_init_regmap(codec, regmap);

@@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec)
 	struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec);
 
 	snd_soc_codec_exit_regmap(codec);
-	snd_soc_free_ac97_codec(wm9712->ac97);
+	if (!wm9712->mfd_pdata)
+		snd_soc_free_ac97_codec(wm9712->ac97);

This bit is still missing the ifdef it has in the preceeding
patch.

Damn, you're right, it's missing in both wm9705 and wm9712, but not in wm9713.
That will be for the hopefully last volley of this serie.

Thanks for spotting that.

Cheers.

-- 
Robert

On Mon, Sep 04, 2017 at 03:14:40PM +0200, Robert Jarzmik wrote:

Charles Keepax [off-list ref] writes:

quoted

This bit is still missing the ifdef it has in the preceeding
patch.

Damn, you're right, it's missing in both wm9705 and wm9712, but not in wm9713.
That will be for the hopefully last volley of this serie.

Given that this just missed the merge window but has now been reviewed
by Takashi as well what I'm thinking is that it's going to be easiest to
apply the start of it now so hopefully no need to respin the whole
series so often.