[PATCH] hid: Fix system-control buttons on a multitouch interface not working

Subsystems: hid core layer, the rest

STALE3279d

3 messages, 2 authors, 2017-08-22 · open the first message on its own page

[PATCH] hid: Fix system-control buttons on a multitouch interface not working

From: Hans de Goede <hidden>
Date: 2017-08-17 10:48:52

Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
interface as a hid-multitouch touch-pad.

This commit fixes these buttons not working.

Signed-off-by: Hans de Goede <redacted>
---
 drivers/hid/hid-multitouch.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 0a8689bb08e9..53d1413cd435 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 	    field->application != HID_DG_PEN &&
 	    field->application != HID_DG_TOUCHPAD &&
 	    field->application != HID_GD_KEYBOARD &&
+	    field->application != HID_GD_SYSTEM_CONTROL &&
 	    field->application != HID_CP_CONSUMER_CONTROL &&
 	    field->application != HID_GD_WIRELESS_RADIO_CTLS &&
 	    !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
-- 
2.13.4

Re: [PATCH] hid: Fix system-control buttons on a multitouch interface not working

From: Benjamin Tissoires <hidden>
Date: 2017-08-22 09:00:41

On Aug 17 2017 or thereabouts, Hans de Goede wrote:
quoted hunk
Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
interface as a hid-multitouch touch-pad.

This commit fixes these buttons not working.

Signed-off-by: Hans de Goede <redacted>
---
 drivers/hid/hid-multitouch.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 0a8689bb08e9..53d1413cd435 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 	    field->application != HID_DG_PEN &&
 	    field->application != HID_DG_TOUCHPAD &&
 	    field->application != HID_GD_KEYBOARD &&
+	    field->application != HID_GD_SYSTEM_CONTROL &&
 	    field->application != HID_CP_CONSUMER_CONTROL &&
 	    field->application != HID_GD_WIRELESS_RADIO_CTLS &&
 	    !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
-- 
2.13.4
Looks like you resent it this morning as https://patchwork.kernel.org/patch/9914313/

We can discard this one then I guess.

Cheers,
Benjamin

Re: [PATCH] hid: Fix system-control buttons on a multitouch interface not working

From: Hans de Goede <hidden>
Date: 2017-08-22 10:06:51

Hi,

On 22-08-17 11:00, Benjamin Tissoires wrote:
On Aug 17 2017 or thereabouts, Hans de Goede wrote:
quoted
Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
interface as a hid-multitouch touch-pad.

This commit fixes these buttons not working.

Signed-off-by: Hans de Goede <redacted>
---
  drivers/hid/hid-multitouch.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 0a8689bb08e9..53d1413cd435 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
  	    field->application != HID_DG_PEN &&
  	    field->application != HID_DG_TOUCHPAD &&
  	    field->application != HID_GD_KEYBOARD &&
+	    field->application != HID_GD_SYSTEM_CONTROL &&
  	    field->application != HID_CP_CONSUMER_CONTROL &&
  	    field->application != HID_GD_WIRELESS_RADIO_CTLS &&
  	    !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
-- 
2.13.4
Looks like you resent it this morning as https://patchwork.kernel.org/patch/9914313/
Yes, sorry I wasn't sure I had send it and google could not find it,
so I assumed I did not send it.
We can discard this one then I guess.
Ack.

Regards,

Hans
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help