[PATCH] input: touchscreen: mxs-lradc: Use devm_ioremap_resource()

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE3331d

2 messages, 2 authors, 2017-06-22 · open the first message on its own page

[PATCH] input: touchscreen: mxs-lradc: Use devm_ioremap_resource()

From: Fabio Estevam <hidden>
Date: 2017-06-21 14:03:45

In case of error devm_ioremap() returns NULL pointer not ERR_PTR().

The iores NULL check is also missing.

Fix both problems by using devm_ioremap_resource() variant instead.

Fixes: d81ca730e3e4 ("input: touchscreen: mxs-lradc: Add support for touchscreen")
Signed-off-by: Fabio Estevam <redacted>
---
 drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
index 58c016c..0f8c9e7 100644
--- a/drivers/input/touchscreen/mxs-lradc-ts.c
+++ b/drivers/input/touchscreen/mxs-lradc-ts.c
@@ -630,7 +630,7 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
 	spin_lock_init(&ts->lock);
 
 	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ts->base = devm_ioremap(dev, iores->start, resource_size(iores));
+	ts->base = devm_ioremap_resource(dev, iores);
 	if (IS_ERR(ts->base))
 		return PTR_ERR(ts->base);
 
-- 
2.7.4

Re: [PATCH] input: touchscreen: mxs-lradc: Use devm_ioremap_resource()

From: Fabio Estevam <festevam@gmail.com>
Date: 2017-06-22 02:44:23

On Wed, Jun 21, 2017 at 11:03 AM, Fabio Estevam [off-list ref] wrote:
quoted hunk
In case of error devm_ioremap() returns NULL pointer not ERR_PTR().

The iores NULL check is also missing.

Fix both problems by using devm_ioremap_resource() variant instead.

Fixes: d81ca730e3e4 ("input: touchscreen: mxs-lradc: Add support for touchscreen")
Signed-off-by: Fabio Estevam <redacted>
---
 drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
index 58c016c..0f8c9e7 100644
--- a/drivers/input/touchscreen/mxs-lradc-ts.c
+++ b/drivers/input/touchscreen/mxs-lradc-ts.c
@@ -630,7 +630,7 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
        spin_lock_init(&ts->lock);

        iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       ts->base = devm_ioremap(dev, iores->start, resource_size(iores));
+       ts->base = devm_ioremap_resource(dev, iores);
        if (IS_ERR(ts->base))
                return PTR_ERR(ts->base);
It seems we cannot use devm_ioremap_resource() in this case as it
shares the resources with the lradc driver:
http://www.spinics.net/lists/linux-iio/msg32864.html

I will send a v2 that does a NULL check on iores.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help