ASUS G752VS Touchpad does not work

Hi KT Liao, Duson Lin,

A user reported that the touchpad on ASUS G752VS does not work [1],
it's an ELAN touchapd.

I did the following change, the touchpad correctly loads elan-i2c
instead of hid-multitouch, but it's still not working.

Thanks.

[1] https://bugs.launchpad.net/bugs/1653456

--

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index da62a7695e77..acddb407e766 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c

@@ -2377,6 +2377,7 @@ static const struct hid_device_id hid_ignore_list[] = {
        { HID_USB_DEVICE(USB_VENDOR_ID_DELORME,

USB_DEVICE_ID_DELORME_EM_LT20) },
        { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x0400) },
        { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x0401) },
+       { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x3043) },
        { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY,
USB_DEVICE_ID_ESSENTIAL_REALITY_P5) },
        { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) },
        { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) },

diff --git a/drivers/input/mouse/elan_i2c_core.c

b/drivers/input/mouse/elan_i2c_core.c
index a26f44c28d82..bf661ce5dccc 100644

--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c

@@ -1235,6 +1238,7 @@ static const struct acpi_device_id elan_acpi_id[] = {
        { "ELAN0600", 0 },
        { "ELAN0605", 0 },
        { "ELAN1000", 0 },
+       { "ELAN1203", 0 },
        { }
 };
 MODULE_DEVICE_TABLE(acpi, elan_acpi_id);

Hi, KT Liao,

On Thu, May 4, 2017 at 5:47 PM, 廖崇榮 [off-list ref] wrote:

Hi Kai-Heng

-----Original Message-----
From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com]
Sent: Thursday, May 04, 2017 3:59 PM
To: kt.liao@emc.com.tw; dusonlin@emc.com.tw
Cc: linux-input@vger.kernel.org
Subject: ASUS G752VS Touchpad does not work

Hi KT Liao, Duson Lin,

A user reported that the touchpad on ASUS G752VS does not work [1], it's an ELAN touchapd.

I did the following change, the touchpad correctly loads elan-i2c instead of hid-multitouch, but it's still not working.

[KT] I check the touchpad of this model, it's MS precision touchpad.
It must use "hid-multitouch", not "elan-i2c".

Well, the touchpad does not work under hid-multitouch, either. That's
why I tried to let it load elan-i2c instead.
What information do you need to investigate this issue?

Thanks.

Hi Kai-Heng

-----Original Message-----
From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com] 
Sent: Thursday, May 04, 2017 3:59 PM
To: kt.liao@emc.com.tw; dusonlin@emc.com.tw
Cc: linux-input@vger.kernel.org
Subject: ASUS G752VS Touchpad does not work

Hi KT Liao, Duson Lin,

A user reported that the touchpad on ASUS G752VS does not work [1], it's an ELAN touchapd.

I did the following change, the touchpad correctly loads elan-i2c instead of hid-multitouch, but it's still not working.

[KT] I check the touchpad of this model, it's MS precision touchpad.
It must use "hid-multitouch", not "elan-i2c".



Thanks.

[1] https://bugs.launchpad.net/bugs/1653456

--

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index da62a7695e77..acddb407e766 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c

@@ -2377,6 +2377,7 @@ static const struct hid_device_id hid_ignore_list[] = {
        { HID_USB_DEVICE(USB_VENDOR_ID_DELORME,

USB_DEVICE_ID_DELORME_EM_LT20) },
        { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x0400) },
        { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x0401) },
+       { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x3043) },
        { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY,
USB_DEVICE_ID_ESSENTIAL_REALITY_P5) },
        { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) },
        { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) }, diff --git a/drivers/input/mouse/elan_i2c_core.c
b/drivers/input/mouse/elan_i2c_core.c
index a26f44c28d82..bf661ce5dccc 100644

--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c

@@ -1235,6 +1238,7 @@ static const struct acpi_device_id elan_acpi_id[] = {
        { "ELAN0600", 0 },
        { "ELAN0605", 0 },
        { "ELAN1000", 0 },
+       { "ELAN1203", 0 },
        { }
 };
 MODULE_DEVICE_TABLE(acpi, elan_acpi_id);

Add Endlessm's Chris in loop

Hi Chris,

Do you know ASUS G752VS's touchpad issue.
It's MS PTP, I am not sure if it meet the same problem that interrupt pin configure issue?

From your last Acer PTP experience, Your issue seems caused by inconsistent INT setting, right?

Could you give some advice to Kai-Heng to check the issue

Thanks  KT



-----Original Message-----
From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com] 
Sent: Thursday, May 04, 2017 5:54 PM
To: 廖崇榮
Cc: linux-input@vger.kernel.org
Subject: Re: ASUS G752VS Touchpad does not work

Hi, KT Liao,

On Thu, May 4, 2017 at 5:47 PM, 廖崇榮 [off-list ref] wrote:

Hi Kai-Heng

-----Original Message-----
From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com]
Sent: Thursday, May 04, 2017 3:59 PM
To: kt.liao@emc.com.tw; dusonlin@emc.com.tw
Cc: linux-input@vger.kernel.org
Subject: ASUS G752VS Touchpad does not work

Hi KT Liao, Duson Lin,

A user reported that the touchpad on ASUS G752VS does not work [1], it's an ELAN touchapd.

I did the following change, the touchpad correctly loads elan-i2c instead of hid-multitouch, but it's still not working.

[KT] I check the touchpad of this model, it's MS precision touchpad.
It must use "hid-multitouch", not "elan-i2c".

Well, the touchpad does not work under hid-multitouch, either. That's why I tried to let it load elan-i2c instead.
What information do you need to investigate this issue?

Thanks.