# Re: \[PATCH 04/13\] Input: keyboard - Use local variables consistently

- From: Linus Walleij \<hidden\>
- Date: 2017-01-26 10:31:05 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2017/01/4920865
- Thread: https://ratatoskr.run/linux-input/2017/01/4917749/t.md

```text
On Sat, Jan 21, 2017 at 7:45 PM, Guenter Roeck [ref] wrote:

> If a function declares a variable to access a structure element,
> use it conssistently.

Weird spelling :)

> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

> -               error = devm_gpio_request_one(&pdev->dev, button->gpio, flags,
> -                                             desc);
> +               error = devm_gpio_request_one(dev, button->gpio, flags, desc);

I think I have changes in the GPIO tree touching these code sites.

I put those on an immutable branch so Dmitry can pull it if he needs
it as a base for this patch:
https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/commit/?h=ib-gpiod-flags

Yours,
Linus Walleij
```
