gpio_key.c device tree question

Hello,

I am trying to see how to disable the sub device nodes in
gpio_keys device node.

I have this in my base dtsi file:

#include "vendor_file.dtsi"

        gpio_keys {
                compatible = "gpio-keys";
                input-name = "gpio-keys";
                pinctrl-names = "gpio_key_active","gpio_key_suspend";
                pinctrl-0 = <&key_active>;
                pinctrl-1 = <&key_suspend>;
                camera_snapshot {
                        label = "camera_snapshot";
                        //snip
                };
        };

I have this in vendor_file.dtsi:
       gpio_keys {
               source_key_1 {
                       label = "source_key_1";
                       //snip
               };
       };

In my current consolidated dtb file all nodes are getting
added i.e. camera_snapshot and source_key_1. How
can i remove camera_snapshot node from the
gpio_keys device node or disable it?


Thanks,

On Sun, Jan 8, 2017 at 7:42 PM, noman pouigt [off-list ref] wrote:

Hello,

I am trying to see how to disable the sub device nodes in
gpio_keys device node.

I have this in my base dtsi file:

#include "vendor_file.dtsi"

        gpio_keys {
                compatible = "gpio-keys";
                input-name = "gpio-keys";
                pinctrl-names = "gpio_key_active","gpio_key_suspend";
                pinctrl-0 = <&key_active>;
                pinctrl-1 = <&key_suspend>;
                camera_snapshot {
                        label = "camera_snapshot";
                        //snip
                };
        };

I have this in vendor_file.dtsi:
       gpio_keys {
               source_key_1 {
                       label = "source_key_1";
                       //snip
               };
       };

In my current consolidated dtb file all nodes are getting
added i.e. camera_snapshot and source_key_1. How
can i remove camera_snapshot node from the
gpio_keys device node or disable it?

This issue is fixed with below commit:

commit 809d9516da73345cca587743b57e45e9095d851e
Author: Laxman Dewangan [off-list ref]
Date:   Wed Jan 13 00:14:19 2016 -0800

    Input: gpio-keys - allow disabling individual buttons in DT

    Add support to disable buttons from DT via status property if given button
    is not supported on given platforms. This will help re-using existing dtsi
    files across multiple platforms.

    Signed-off-by: Laxman Dewangan [off-list ref]
    Signed-off-by: Dmitry Torokhov [off-list ref]

Thanks,