# Re: \[PATCH v2 0/4\] Input: xpad - improve support for new Xbox One S pad

- From: Cameron Gutman \<hidden\>
- Date: 2016-10-04 19:29:43 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2016/10/8928541
- Thread: https://ratatoskr.run/linux-input/2016/08/8928365/t.md

```text
On 08/15/2016 09:10 PM, Cameron Gutman wrote:
> This pad generally works well enough on the current xpad, but there are
> a few usability issues that I'm fixing with this series.
> 
> The notable changes:
> 
> The protocol seems to have changed a bit with the new pad. For one, it
> needs an ack for the mode report now, otherwise it just retransmits it
> forever. This makes the mode button look stuck down to userspace after
> the first time it is pressed.
> 
> It also seems to overflow some internal buffer, hang, then eventually
> reset the pad if there is user input without the driver listening.
> This causes a spurious disconnection that may cause userspace programs
> to behave unexpectedly.
> 
> Changes in v2:
> Fixed multi-line comment style in patch 2 and 3 to be consistent with
> the existing code. I've also added a simple patch to address rumble
> issues on all Xbox One pads, including Xbox One S.
> 
> Cameron Gutman (4):
>   Input: xpad - add device ID for Xbox One S pad
>   Input: xpad - fix One S pad disconnecting when not opened
>   Input: xpad - fix stuck mode button on Xbox One S pad
>   Input: xpad - fix Xbox One rumble stopping after 2.5 secs
> 
>  drivers/input/joystick/xpad.c | 60 ++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 54 insertions(+), 6 deletions(-)
> 

Hi Dmitry,

I'm just following up on these patches. Do you want any changes or are they
fine as is?

Pavel has already applied the patches to his out-of-tree xpad driver [0].

[0] https://github.com/paroj/xpad

Thanks,
Cameron
```
