# Re: \[PATCH -next\] HID: intel\_ish-hid: Use kzalloc instead of kmalloc/memset

- From: Srinivas Pandruvada \<srinivas.pandruvada@linux.intel.com\>
- Date: 2016-08-26 19:05:34 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2016/08/8928401
- Thread: https://ratatoskr.run/linux-input/2016/08/8928382/t.md

```text
On Sun, 2016-08-21 at 15:30 +0000, Wei Yongjun wrote:
> Use kzalloc rather than kmalloc followed by memset with 0.
> 
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 
> Signed-off-by: Wei Yongjun <redacted>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  drivers/hid/intel-ish-hid/ishtp/client-buffers.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
> b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
> index 3f5ce5e..b9b917d 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
> @@ -73,11 +73,10 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
>  	for (j = 0; j < cl->tx_ring_size; ++j) {
>  		struct ishtp_cl_tx_ring	*tx_buf;
>  
> -		tx_buf = kmalloc(sizeof(struct ishtp_cl_tx_ring),
> GFP_KERNEL);
> +		tx_buf = kzalloc(sizeof(struct ishtp_cl_tx_ring),
> GFP_KERNEL);
>  		if (!tx_buf)
>  			goto	out;
>  
> -		memset(tx_buf, 0, sizeof(struct ishtp_cl_tx_ring));
>  		tx_buf->send_buf.data = kmalloc(len, GFP_KERNEL);
>  		if (!tx_buf->send_buf.data) {
>  			kfree(tx_buf);
> 
> 
> 
```