# \[PATCH -next\] HID: intel\_ish-hid: Convert list\_for\_each to entry variant

- From: Wei Yongjun \<hidden\>
- Date: 2016-08-21 15:30:53 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2016/08/8928381
- Thread: https://ratatoskr.run/linux-input/2016/08/8928381/t.md

```text
convert list_for_each() to list_for_each_entry() where
applicable.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index 0183eac..8a1bb8c 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -380,11 +380,9 @@ static struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
 	struct ishtp_cl_device *device;
 	int status;
 	unsigned long flags;
-	struct list_head *pos;
 
 	spin_lock_irqsave(&dev->device_list_lock, flags);
-	list_for_each(pos, &dev->device_list) {
-		device = list_entry(pos, struct ishtp_cl_device, device_link);
+	list_for_each_entry(device, &dev->device_list, device_link) {
 		if (!strcmp(name, dev_name(&device->dev))) {
 			device->fw_client = &dev->fw_clients[
 				dev->fw_client_presentation_num - 1];



```
