# Re: \[PATCH 0289/1285\] Replace numeric parameter like 0444 with macro

- From: Michael Hennerich \<michael.hennerich@analog.com\>
- Date: 2016-08-02 14:48:19 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2016/08/8928299
- Thread: https://ratatoskr.run/linux-input/2016/08/4805487/t.md

```text
On 02.08.2016 12:57, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <redacted>
> Signed-off-by: Baole Ni <redacted>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/input/touchscreen/ad7879.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c
> index e4bf110..83be4c5 100644
> --- a/drivers/input/touchscreen/ad7879.c
> +++ b/drivers/input/touchscreen/ad7879.c
> @@ -364,7 +364,7 @@ static ssize_t ad7879_disable_store(struct device *dev,
>  	return count;
>  }
>
> -static DEVICE_ATTR(disable, 0664, ad7879_disable_show, ad7879_disable_store);
> +static DEVICE_ATTR(disable, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, ad7879_disable_show, ad7879_disable_store);
>
>  static struct attribute *ad7879_attributes[] = {
>  	&dev_attr_disable.attr,
>


-- 
Greetings,
Michael

--
Analog Devices GmbH      Otl-Aicher Strasse 60-64      80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne
```