[PATCH] Input: joystick - enable interrupts

DORMANTno replies

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2016-08-31 15:34:45
Also in: lkml
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Dmitry Torokhov, Linus Torvalds

The irq was disabled before reading from the gameport. After reading
we should enable it. Instead we were restoring it back to the previous
state before starting the do-while loop.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/input/joystick/analog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/joystick/analog.c b/drivers/input/joystick/analog.c
index 3d8ff09..faa90bc 100644
--- a/drivers/input/joystick/analog.c
+++ b/drivers/input/joystick/analog.c
@@ -275,7 +275,7 @@ static int analog_cooked_read(struct analog_port *port)
 		local_irq_disable();
 		this = gameport_read(gameport) & port->mask;
 		now = get_time();
-		local_irq_restore(flags);
+		local_irq_enable();
 
 		if ((last ^ this) && (delta(loop, now) < loopout)) {
 			data[i] = last ^ this;
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help