[PATCH] Input: focaltech - mark focaltech_set_resolution() static

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE3656d

3 messages, 3 authors, 2016-09-05 · open the first message on its own page

[PATCH] Input: focaltech - mark focaltech_set_resolution() static

From: Baoyou Xie <hidden>
Date: 2016-08-31 08:38:14

We get 1 warning when building kernel with W=1:
drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.

Signed-off-by: Baoyou Xie <redacted>
---
 drivers/input/mouse/focaltech.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c
index c8c6a8c..d3ca02a 100644
--- a/drivers/input/mouse/focaltech.c
+++ b/drivers/input/mouse/focaltech.c
@@ -390,7 +390,8 @@ static int focaltech_read_size(struct psmouse *psmouse)
 	return 0;
 }
 
-void focaltech_set_resolution(struct psmouse *psmouse, unsigned int resolution)
+static void
+focaltech_set_resolution(struct psmouse *psmouse, unsigned int resolution)
 {
 	/* not supported yet */
 }
-- 
2.7.4

Re: [PATCH] Input: focaltech - mark focaltech_set_resolution() static

From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-08-31 10:04:23

On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote:
We get 1 warning when building kernel with W=1:
drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.

Signed-off-by: Baoyou Xie <redacted>
Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH] Input: focaltech - mark focaltech_set_resolution() static

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2016-09-05 17:33:55

On Wed, Aug 31, 2016 at 11:58:50AM +0200, Arnd Bergmann wrote:
On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote:
quoted
We get 1 warning when building kernel with W=1:
drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.

Signed-off-by: Baoyou Xie <redacted>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.


-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help