# Re: \[PATCH 1/3\] input: pixcir\_i2c\_ts: simplify code with of\_device\_get\_match\_data

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2016-08-19 17:17:52 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2016/08/4818524
- Thread: https://ratatoskr.run/linux-input/2016/08/4816457/t.md

```text
On Wed, Aug 17, 2016 at 03:22:12PM +0200, LABBE Corentin wrote:
> The usage of of_device_get_match_data reduce the code size a bit.
> Furthermore, it is better to use a standard function for
> getting the match data.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/pixcir_i2c_ts.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index d159e14..b0a2dc2 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -431,13 +431,7 @@ static const struct of_device_id pixcir_of_match[];
>  static int pixcir_parse_dt(struct device *dev,
>  			   struct pixcir_i2c_ts_data *tsdata)
>  {
> -	const struct of_device_id *match;
> -
> -	match = of_match_device(of_match_ptr(pixcir_of_match), dev);
> -	if (!match)
> -		return -EINVAL;
> -
> -	tsdata->chip = (const struct pixcir_i2c_chip_data *)match->data;
> +	tsdata->chip = of_device_get_match_data(dev);
>  	if (!tsdata->chip)
>  		return -EINVAL;
>  
> -- 
> 2.7.3
> 

-- 
Dmitry
```