[PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE3762d

2 messages, 2 authors, 2016-07-05 · open the first message on its own page

[PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data

From: Andrew Duggan <hidden>
Date: 2016-06-25 00:19:19

The pointer to struct rmi_function in f12_data is never set and was never
used. The fn pointer is also stored in rmi_2d_sensor which is a member of
f12_data.

Signed-off-by: Andrew Duggan <redacted>
---
 drivers/input/rmi4/rmi_f12.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
index 041a91d..7d66766 100644
--- a/drivers/input/rmi4/rmi_f12.c
+++ b/drivers/input/rmi4/rmi_f12.c
@@ -27,7 +27,6 @@ enum rmi_f12_object_type {
 };
 
 struct f12_data {
-	struct rmi_function *fn;
 	struct rmi_2d_sensor sensor;
 	struct rmi_2d_sensor_platform_data sensor_pdata;
 	bool has_dribble;
-- 
2.5.0

Re: [PATCH v2 5/8] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data

From: Nick Dyer <hidden>
Date: 2016-07-05 10:19:44

On 25/06/2016 01:19, Andrew Duggan wrote:
The pointer to struct rmi_function in f12_data is never set and was never
used. The fn pointer is also stored in rmi_2d_sensor which is a member of
f12_data.

Signed-off-by: Andrew Duggan <redacted>
Reviewed-by: Nick Dyer <nick@shmanahar.org>
quoted hunk
---
 drivers/input/rmi4/rmi_f12.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
index 041a91d..7d66766 100644
--- a/drivers/input/rmi4/rmi_f12.c
+++ b/drivers/input/rmi4/rmi_f12.c
@@ -27,7 +27,6 @@ enum rmi_f12_object_type {
 };
 
 struct f12_data {
-	struct rmi_function *fn;
 	struct rmi_2d_sensor sensor;
 	struct rmi_2d_sensor_platform_data sensor_pdata;
 	bool has_dribble;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help