# Re: \[PATCH 2/6\] hid: intel\_ish-hid: ISH Transport layer

- From: Jiri Kosina \<jikos@kernel.org\>
- Date: 2016-06-17 20:45:35 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2016/06/4776655
- Thread: https://ratatoskr.run/linux-input/2016/06/4771023/t.md

```text
On Fri, 17 Jun 2016, Jiri Kosina wrote:

> > +struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
> > +					     uuid_le uuid, char *name)
> > +{
> 
> Should be static.

Actually, going deeper into the code and trying to untangle all the 
dependencies, there are quite a few more in other ipc.c, hid-client.c, 
etc. Please fix that globally in the next iteration.

Thanks,

-- 
Jiri Kosina
SUSE Labs
```
