[PATCH] Remove ARCH_SHMOBILE

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE3886d

6 messages, 5 authors, 2016-03-03 · open the first message on its own page

[PATCH] Remove ARCH_SHMOBILE

From: Simon Horman <hidden>
Date: 2016-03-02 01:55:54

Since the removal of legacy (non-multiplatform) support this driver has not
been used by any Renesas ARM based SoCs.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <redacted>
---
 drivers/input/keyboard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on v4.5-rc1
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index ddd8148d51d7..984532c6e689 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -560,7 +560,7 @@ config KEYBOARD_SUNKBD
 
 config KEYBOARD_SH_KEYSC
 	tristate "SuperH KEYSC keypad support"
-	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
+	depends on SUPERH || COMPILE_TEST
 	help
 	  Say Y here if you want to use a keypad attached to the KEYSC block
 	  on SuperH processors such as sh7722 and sh7343.
-- 
2.1.4

Re: [PATCH] Remove ARCH_SHMOBILE

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-03-02 09:30:36

Hi Simon,

On Wed, Mar 2, 2016 at 2:55 AM, Simon Horman [off-list ref] wrote:
[PATCH] Remove ARCH_SHMOBILE
Please use a more appropriate one-line summary.
quoted hunk
Since the removal of legacy (non-multiplatform) support this driver has not
been used by any Renesas ARM based SoCs.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <redacted>
---
 drivers/input/keyboard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on v4.5-rc1
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index ddd8148d51d7..984532c6e689 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -560,7 +560,7 @@ config KEYBOARD_SUNKBD

 config KEYBOARD_SH_KEYSC
        tristate "SuperH KEYSC keypad support"
-       depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
+       depends on SUPERH || COMPILE_TEST
I think dropping the SUPERH dependency is the right approach here, as all
SuperH platforms using the driver select ARCH_SHMOBILE.

"sh_keysc" is used on SH_MIGOR, SH_ECOVEC, SH_KFR2R09, SH_7722_SOLUTION_ENGINE,
and SH_7724_SOLUTION_ENGINE, which depend on either CPU_SUBTYPE_SH7722 or
CPU_SUBTYPE_SH7724, and both select ARCH_SHMOBILE.
        help
          Say Y here if you want to use a keypad attached to the KEYSC block
          on SuperH processors such as sh7722 and sh7343.
FWIW, this has never been enabled on sh7343. But CPU_SUBTYPE_SH7343 also
selects ARCH_SHMOBILE, so we're safe.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] Remove ARCH_SHMOBILE

From: Sergei Shtylyov <hidden>
Date: 2016-03-02 13:18:51

I think you forgot a proper prefix in the subject...

Re: [PATCH] Remove ARCH_SHMOBILE

From: Magnus Damm <magnus.damm@gmail.com>
Date: 2016-03-02 16:00:31

On Wed, Mar 2, 2016 at 6:30 PM, Geert Uytterhoeven [off-list ref] wrote:
On Wed, Mar 2, 2016 at 2:55 AM, Simon Horman [off-list ref] wrote:
quoted
[PATCH] Remove ARCH_SHMOBILE
Please use a more appropriate one-line summary.
quoted
Since the removal of legacy (non-multiplatform) support this driver has not
been used by any Renesas ARM based SoCs.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <redacted>
---
 drivers/input/keyboard/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on v4.5-rc1
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index ddd8148d51d7..984532c6e689 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -560,7 +560,7 @@ config KEYBOARD_SUNKBD

 config KEYBOARD_SH_KEYSC
        tristate "SuperH KEYSC keypad support"
-       depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
+       depends on SUPERH || COMPILE_TEST
I think dropping the SUPERH dependency is the right approach here, as all
SuperH platforms using the driver select ARCH_SHMOBILE.
Thanks, I agree!
"sh_keysc" is used on SH_MIGOR, SH_ECOVEC, SH_KFR2R09, SH_7722_SOLUTION_ENGINE,
and SH_7724_SOLUTION_ENGINE, which depend on either CPU_SUBTYPE_SH7722 or
CPU_SUBTYPE_SH7724, and both select ARCH_SHMOBILE.
quoted
        help
          Say Y here if you want to use a keypad attached to the KEYSC block
          on SuperH processors such as sh7722 and sh7343.
FWIW, this has never been enabled on sh7343. But CPU_SUBTYPE_SH7343 also
selects ARCH_SHMOBILE, so we're safe.
You are right that the SH architecture is the main consumer at this
point. I do however vaguely recall ARM shmobile G3EVM and G4EVM
including sh7367 and some other SoC also having a KEYSC hardware block
included. Due to the iffy interrupt controller upstream support for
those boards/socs were killed off quite some time ago while (not)
migrating to DT. So I think this KEYSC driver is simply a left over
from that time.

Cheers,

/ magnus

Re: [PATCH] Remove ARCH_SHMOBILE

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-03-02 16:08:52

Hi Magnus,

On Wed, Mar 2, 2016 at 5:00 PM, Magnus Damm [off-list ref] wrote:
On Wed, Mar 2, 2016 at 6:30 PM, Geert Uytterhoeven [off-list ref] wrote:
quoted
On Wed, Mar 2, 2016 at 2:55 AM, Simon Horman [off-list ref] wrote:
quoted
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -560,7 +560,7 @@ config KEYBOARD_SUNKBD

 config KEYBOARD_SH_KEYSC
        tristate "SuperH KEYSC keypad support"
-       depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
+       depends on SUPERH || COMPILE_TEST
I think dropping the SUPERH dependency is the right approach here, as all
SuperH platforms using the driver select ARCH_SHMOBILE.
Thanks, I agree!
quoted
"sh_keysc" is used on SH_MIGOR, SH_ECOVEC, SH_KFR2R09, SH_7722_SOLUTION_ENGINE,
and SH_7724_SOLUTION_ENGINE, which depend on either CPU_SUBTYPE_SH7722 or
CPU_SUBTYPE_SH7724, and both select ARCH_SHMOBILE.
quoted
        help
          Say Y here if you want to use a keypad attached to the KEYSC block
          on SuperH processors such as sh7722 and sh7343.
FWIW, this has never been enabled on sh7343. But CPU_SUBTYPE_SH7343 also
selects ARCH_SHMOBILE, so we're safe.
You are right that the SH architecture is the main consumer at this
point. I do however vaguely recall ARM shmobile G3EVM and G4EVM
including sh7367 and some other SoC also having a KEYSC hardware block
included. Due to the iffy interrupt controller upstream support for
those boards/socs were killed off quite some time ago while (not)
migrating to DT. So I think this KEYSC driver is simply a left over
from that time.
Note that sh73a0 also has keysc, but I don't think it's usable on kzm9g
(after a quick look at the schematics).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] Remove ARCH_SHMOBILE

From: Simon Horman <horms@verge.net.au>
Date: 2016-03-03 00:09:11

On Wed, Mar 02, 2016 at 04:18:48PM +0300, Sergei Shtylyov wrote:
I think you forgot a proper prefix in the subject...
Indeed, sorry about that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help