# Re: \[PATCH\] driver: input :touchscreen : add Raydium I2C touch driver

- From: Joe Perches \<joe@perches.com\>
- Date: 2016-03-03 03:55:36 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2016/03/4699982
- Thread: https://ratatoskr.run/linux-input/2016/03/4699929/t.md

```text
On Thu, 2016-03-03 at 03:14 +0000, Jeffrey Lin (林義章) wrote:
> Hi Joe:
> Thank you for your response. I'll follow your comments in next version.

OK, btw: the below looks very odd

> > +static int raydium_i2c_send_message(struct i2c_client *client,
> > +	size_t len, void *data)
> > +{
> > +	int error;
> > +	u8 buf[HEADER_SIZE], ii;
> > +
> > +	for (ii = 0; ii < HEADER_SIZE; ii++)
> > +		buf[ii] = ((u8 *)data)[3 - ii];

It intermixes a #define of 4 with a hard declaration of 3
to reverse copy a byte array of length HEADER_SIZE.

Maybe use:
	for (ii = 0; ii < HEADER_SIZE; ii++)
		buf[ii] = ((u8 *)data)[HEADER_SIZE - 1 - ii]
```