[PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

Subsystems: hid core layer, the rest

STALE4032d

4 messages, 4 authors, 2015-09-29 · open the first message on its own page

[PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2015-09-28 14:22:26

Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
the device as "Touchpad".

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/hid/hid-multitouch.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 426b2f1a3450..661b4fce1a5d 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c

@@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
 		case HID_DG_TOUCHSCREEN:
 			/* we do not set suffix = "Touchscreen" */
 			break;
+		case HID_DG_TOUCHPAD:
+			suffix = "Touchpad";
+			break;
 		case HID_GD_SYSTEM_CONTROL:
 			suffix = "System Control";
 			break;

-- 
2.5.1

Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

From: Daniel Martin <hidden>
Date: 2015-09-29 06:37:30

On 28 September 2015 at 16:22, Mika Westerberg
[off-list ref] wrote:

quoted hunk

Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
the device as "Touchpad".

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/hid/hid-multitouch.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 426b2f1a3450..661b4fce1a5d 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c

@@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
                case HID_DG_TOUCHSCREEN:
                        /* we do not set suffix = "Touchscreen" */
                        break;
+               case HID_DG_TOUCHPAD:
+                       suffix = "Touchpad";
+                       break;
                case HID_GD_SYSTEM_CONTROL:
                        suffix = "System Control";
                        break;
--

I will drop my locally pending patch for this. ;)

Reviewed-by: Daniel Martin <redacted>

Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

From: Benjamin Tissoires <hidden>
Date: 2015-09-29 09:05:22

On Sep 28 2015 or thereabouts, Mika Westerberg wrote:

Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
the device as "Touchpad".

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---

Acked-by: Benjamin Tissoires <redacted>

Cheers,
Benjamin

quoted hunk

 drivers/hid/hid-multitouch.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 426b2f1a3450..661b4fce1a5d 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c

@@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
 		case HID_DG_TOUCHSCREEN:
 			/* we do not set suffix = "Touchscreen" */
 			break;
+		case HID_DG_TOUCHPAD:
+			suffix = "Touchpad";
+			break;
 		case HID_GD_SYSTEM_CONTROL:
 			suffix = "System Control";
 			break;

-- 
2.5.1

Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD

From: Jiri Kosina <jikos@kernel.org>
Date: 2015-09-29 10:09:07

On Mon, 28 Sep 2015, Mika Westerberg wrote:

Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
the device as "Touchpad".

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Applied to hid.git#for-4.4/multitouch.

-- 
Jiri Kosina
SUSE Labs

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help