[PATCH] Input: elan_i2c - fix X205TA iap version

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE4058d

2 messages, 2 authors, 2015-09-12 · open the first message on its own page

[PATCH] Input: elan_i2c - fix X205TA iap version

From: Michele Curti <hidden>
Date: 2015-09-12 07:24:57

After commit commit 58f1eae48e53 ("Input: elan_i2c - use iap_version to
get firmware information") the touchpad on the Asus X205TA does not 
work anymore, iap version is 0, so modify the switch-case index.

The 0x08 case was added for the X205TA in commit 534fcb3bdaab ("Input:
elan_i2c - enable ELAN0100 acpi panels")

Signed-off-by: Michele Curti <redacted>
---
 drivers/input/mouse/elan_i2c_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index fa94530..c40a02d 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -98,7 +98,7 @@ static int elan_get_fwinfo(u8 iap_version, u16 *validpage_count,
 			   u16 *signature_address)
 {
 	switch (iap_version) {
-	case 0x08:
+	case 0x00:
 		*validpage_count = 512;
 		break;
 	case 0x09:
-- 
2.5.1

Re: [PATCH] Input: elan_i2c - fix X205TA iap version

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-09-12 16:14:24

HI Michele,

On Sat, Sep 12, 2015 at 12:24 AM, Michele Curti [off-list ref] wrote:
After commit commit 58f1eae48e53 ("Input: elan_i2c - use iap_version to
get firmware information") the touchpad on the Asus X205TA does not
work anymore, iap version is 0, so modify the switch-case index.

The 0x08 case was added for the X205TA in commit 534fcb3bdaab ("Input:
elan_i2c - enable ELAN0100 acpi panels")
I'll sit on this patch a bit - I have a feeling will have to revert
58f1eae48e53.

Thanks.
quoted hunk
Signed-off-by: Michele Curti <redacted>
---
 drivers/input/mouse/elan_i2c_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index fa94530..c40a02d 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -98,7 +98,7 @@ static int elan_get_fwinfo(u8 iap_version, u16 *validpage_count,
                           u16 *signature_address)
 {
        switch (iap_version) {
-       case 0x08:
+       case 0x00:
                *validpage_count = 512;
                break;
        case 0x09:
--
2.5.1
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help