Re: [PATCH] Input: cyapa: remove variable overwriting
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-09-28 22:43:08
Also in:
lkml
Hi Sudip, On Tue, Sep 15, 2015 at 3:06 AM, Sudip Mukherjee [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Even if rotat_align is true or false the final value of cyapa->electrodes_rx is always cyapa->electrodes_y. remove the variable overwriting and in the process remove the variable rotat_align which is not required any more. Signed-off-by: Sudip Mukherjee <redacted> --- drivers/input/mouse/cyapa_gen6.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)diff --git a/drivers/input/mouse/cyapa_gen6.c b/drivers/input/mouse/cyapa_gen6.c index 5f19107..f0c614b 100644 --- a/drivers/input/mouse/cyapa_gen6.c +++ b/drivers/input/mouse/cyapa_gen6.c@@ -196,7 +196,6 @@ static int cyapa_gen6_read_sys_info(struct cyapa *cyapa) u8 resp_data[PIP_READ_SYS_INFO_RESP_LENGTH]; int resp_len; u16 product_family; - u8 rotat_align; int error; /* Get App System Information to determine Gen5 or Gen6. */@@ -241,14 +240,7 @@ static int cyapa_gen6_read_sys_info(struct cyapa *cyapa) memcpy(&cyapa->product_id[13], &resp_data[62], 2); cyapa->product_id[15] = '\0'; - rotat_align = resp_data[68]; - if (rotat_align) { - cyapa->electrodes_rx = cyapa->electrodes_y; - cyapa->electrodes_rx = cyapa->electrodes_y; - } else { - cyapa->electrodes_rx = cyapa->electrodes_x; - cyapa->electrodes_rx = cyapa->electrodes_y; - } + cyapa->electrodes_rx = cyapa->electrodes_y;
II think it was probably a typo rather than rotat_align being not needed. Dudley? Thanks. -- Dmitry