[PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE3987d

2 messages, 2 authors, 2015-09-03 · open the first message on its own page

[PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver

From: Luis de Bethencourt <hidden>
Date: 2015-08-29 10:50:59

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <redacted>
---

Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
As suggested by Dmitry Torokhov.

Thanks for the review Dmitry,
Luis

 drivers/input/touchscreen/mms114.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
index 67c0d31..df778f4 100644
--- a/drivers/input/touchscreen/mms114.c
+++ b/drivers/input/touchscreen/mms114.c
@@ -572,6 +572,7 @@ static const struct of_device_id mms114_dt_match[] = {
 	{ .compatible = "melfas,mms114" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, mms114_dt_match);
 #endif
 
 static struct i2c_driver mms114_driver = {
-- 
2.4.6

Re: [PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-09-03 17:54:20

On Sat, Aug 29, 2015 at 12:50:55PM +0200, Luis de Bethencourt wrote:
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <redacted>
Already have this one as well.
quoted hunk
---

Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
As suggested by Dmitry Torokhov.

Thanks for the review Dmitry,
Luis

 drivers/input/touchscreen/mms114.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
index 67c0d31..df778f4 100644
--- a/drivers/input/touchscreen/mms114.c
+++ b/drivers/input/touchscreen/mms114.c
@@ -572,6 +572,7 @@ static const struct of_device_id mms114_dt_match[] = {
 	{ .compatible = "melfas,mms114" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, mms114_dt_match);
 #endif
 
 static struct i2c_driver mms114_driver = {
-- 
2.4.6
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help