[PATCH v2 2/6] input: pwm-beeper: Fix module autoload for OF platform driver

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE3985d

2 messages, 2 authors, 2015-09-03 · open the first message on its own page

[PATCH v2 2/6] input: pwm-beeper: Fix module autoload for OF platform driver

From: Luis de Bethencourt <hidden>
Date: 2015-08-29 10:45:43

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <redacted>
---

Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
As suggested by Dmitry Torokhov.

Thanks,
Luis

 drivers/input/misc/pwm-beeper.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index e82edf8..f2261ab 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -173,6 +173,7 @@ static const struct of_device_id pwm_beeper_match[] = {
 	{ .compatible = "pwm-beeper", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, pwm_beeper_match);
 #endif
 
 static struct platform_driver pwm_beeper_driver = {
-- 
2.4.6

Re: [PATCH v2 2/6] input: pwm-beeper: Fix module autoload for OF platform driver

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-09-03 17:50:11

On Sat, Aug 29, 2015 at 12:45:38PM +0200, Luis de Bethencourt wrote:
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <redacted>
Applied, thank you.
quoted hunk
---

Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
As suggested by Dmitry Torokhov.

Thanks,
Luis

 drivers/input/misc/pwm-beeper.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index e82edf8..f2261ab 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -173,6 +173,7 @@ static const struct of_device_id pwm_beeper_match[] = {
 	{ .compatible = "pwm-beeper", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, pwm_beeper_match);
 #endif
 
 static struct platform_driver pwm_beeper_driver = {
-- 
2.4.6
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help