Re: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write

2 messages, 2 authors, 2015-07-14 · open the first message on its own page

Re: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write

From: Wolfram Sang <hidden>
Date: 2015-07-14 15:49:39

This is a MFD; should be split in GPIO and I2C, then each part moved
in its respective tree.
Yes, this is the conclusion we drew last time, too. It might seem
overkill for such simple devices, still this case shows how much drivers
can suffer if missing the expertise of the apropriate subsystem. That
being said, world is full of cornercases, I agree.
Anyone already working in this direction?
I'd be very surprised :)

Re: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write

From: Ellen Wang <hidden>
Date: 2015-07-14 22:51:25

On 07/14/2015 08:49 AM, Wolfram Sang wrote:
quoted
This is a MFD; should be split in GPIO and I2C, then each part moved
in its respective tree.
Yes, this is the conclusion we drew last time, too. It might seem
overkill for such simple devices, still this case shows how much drivers
can suffer if missing the expertise of the apropriate subsystem. That
being said, world is full of cornercases, I agree.
This driver is a good example of that (missing expertise).  It seems to 
be a fine HID driver but a lot of the I2C details were just wrong.  At 
the same time, I have no idea whether the GPIO part works at all.
quoted
Anyone already working in this direction?
I'd be very surprised :)
I could and would but I'm really not in a good position to do it.  My 
only sample hardware is in a network switch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help