# Re: \[PATCH 1/1\] Elantech touchpad detection fix for laptops

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2015-01-08 01:23:12 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2015/01/8925180
- Thread: https://ratatoskr.run/linux-input/2014/12/4399584/t.md

```text
On Wed, Jan 07, 2015 at 08:11:36PM +1100, Srihari Vijayaraghavan wrote:
> On 7 January 2015 at 19:23, Srihari Vijayaraghavan
> [ref] wrote:
> > On 7 January 2015 at 18:44, Dmitry Torokhov [ref] wrote:
> >> Hi Srihari,
> >
> > Hello Dimitry,
> >
> > Thanks for your feedback. Much appreciated.
> >
> >> On Mon, Jan 05, 2015 at 07:45:39PM +1100, Srihari Vijayaraghavan wrote:
> >>> Hello Folks & Dmitry,
> >>>
> >>> Further to the previous patch, here is the current version (against
> >>> mainline) updated with the DMI info of another laptop model where this
> >>> fix had helped a user.
> >>>
> >>> Can you please review it & give some feedback? If it looks good as it
> >>> is, then on behalf of all affected users (including yours truly), may
> >>> I request for it to be merged upstream (and possibly stable too)?
> >>>
> >>> (If the patch gets spoiled by gmail, please ref to this bugzilla URL,
> >>> where this patch is there as a file attachment:
> >>> https://bugzilla.kernel.org/show_bug.cgi?id=81331)
> >>
> >> I am not terribly happy with having fiddling with keyboard from i8042
> >> core, but I guess that's what we have to do unless someone has better
> >> idea...
> >
> > Agreed 100%. Regrettably, seeing how psmouse_do_detect() doesn't even
> > get invoked, this heavy handed approach had to be taken at i8042 core.
> > However, as you've pointed out, if there is any better idea, we're all
> > ears.
> >
> >> I'll drop mention of Elantech from the option though as it may well be
> >> needed for other devices in the future.
> >
> > A version of the patch (against mainline) incorporating your ideas
> > (i.e., without too much Elantech bashing) is attached to this email
> > for your review.
> >
> >> Thanks!
> 
> [Sorry to respond to my own email.]
> 
> Here's a better version, removing Elantech ref from the table name.

Applied after massaging messages some more. Thank you.

-- 
Dmitry
```