# Re: \[PATCH 11/15\] sound: soc: poodle: make use of new locomo GPIO interface

- From: Dmitry Eremin-Solenikov \<hidden\>
- Date: 2014-10-28 16:45:18 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2014/10/8500361
- Thread: https://ratatoskr.run/alsa-devel/2014/10/8500361/t.md

```text
On 10/28/2014 05:58 PM, Mark Brown wrote:
> On Tue, Oct 28, 2014 at 03:02:04AM +0300, Dmitry Eremin-Solenikov wrote:
>> Since LoCoMo driver has been converted to provide proper gpiolib
>> interface, make poodle ASoC platform driver use gpiolib API.
>
> Please use subject lines matching the style for the subsystem.
>
>> +	ret = gpio_request_array(poodle_gpios, ARRAY_SIZE(poodle_gpios));
>> +	if (ret) {
>> +		dev_err(&pdev->dev, "gpio_request_array() failed: %d\n",
>> +				ret);
>> +		return ret;
>> +	}
>
> I sense a need for devm_gpio_request_array() here.  Otherwise this looks
> fine - ideally it'd move to gpiod but moving to gpiolib is a clear win
> so no need to block on this.

I like the idea of devm_gpio_request_array. But I would like not to add additional (core) patches to this patchset.

>
> Acked-by: Mark Brown <redacted>
>
> with at least the subject line fixed.

Subject line fixed.

-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
```