[ This is essentially a resend, adding Javiers reviewed-by and fixing some small
identation issues in the second patch. Also added Wolfgang and Dimitry in the
to, as i missed them last time ]
The ChromeOS EC MFD driver registers its sub-devices with both a (platform)
name and an OF compatibility string. As a result of this the modalias passed on
to user-space will be based on the OF compatibility string. Thus to be able to
rely on autoloading in case the subdevices are build as modules they need to
export the necessary module aliases based to match the of information.
The two patches in these series add the requird of match information to the EC
subdevices
I guess the first patch should through the i2c tree while the second one would
be for the input tree?
Sjoerd Simons (2):
i2c: cros-ec-tunnel: Add of match table
input: cros_ec_keyb: Add of match table
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 9 +++++++++
drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
2 files changed, 18 insertions(+)
--
2.1.0
To enable the cros-ec-tunnel driver to be auto-loaded when build as a
module add an of match table (and export it) to match the modalias
information passed on to userspace as the Cros EC MFD driver registers
the MFD subdevices with an of_compatibility string.
Signed-off-by: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Reviewed-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
---
Changes in v2: none
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 9 +++++++++
1 file changed, 9 insertions(+)
To enable the cros_ec_keyb driver to be auto-loaded when build as
module add an of match table (and export it) to match the modalias
information passed on to userspace as the Cros EC MFD driver registers
the MFD subdevices with an of_compatibility string.
Signed-off-by: Sjoerd Simons <redacted>
Reviewed-by: Javier Martinez Canillas <redacted>
---
Changes in v2: Fixed some indentation issues
drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
1 file changed, 9 insertions(+)
From: Wolfram Sang <hidden> Date: 2014-09-29 20:59:23
On Fri, Sep 19, 2014 at 10:08:12AM +0200, Sjoerd Simons wrote:
To enable the cros-ec-tunnel driver to be auto-loaded when build as a
module add an of match table (and export it) to match the modalias
information passed on to userspace as the Cros EC MFD driver registers
the MFD subdevices with an of_compatibility string.
Signed-off-by: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Reviewed-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Applied to for-next, thanks!
However, since you are working on this driver: sparse rightfully
complains about:
drivers/i2c/busses/i2c-cros-ec-tunnel.c:97:44: warning: cast truncates bits from constant value (10000 becomes 0)
I don't know the EC protocol, can you check?
From: Javier Martinez Canillas <hidden> Date: 2014-09-29 23:21:38
Hello Wolfram,
On 09/29/2014 10:59 PM, Wolfram Sang wrote:
On Fri, Sep 19, 2014 at 10:08:12AM +0200, Sjoerd Simons wrote:
quoted
To enable the cros-ec-tunnel driver to be auto-loaded when build as a
module add an of match table (and export it) to match the modalias
information passed on to userspace as the Cros EC MFD driver registers
the MFD subdevices with an of_compatibility string.
Signed-off-by: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Reviewed-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Applied to for-next, thanks!
However, since you are working on this driver: sparse rightfully
complains about:
drivers/i2c/busses/i2c-cros-ec-tunnel.c:97:44: warning: cast truncates bits from constant value (10000 becomes 0)
I don't know the EC protocol, can you check?
Doug posted a patch [0] to fix the issue you are reporting but it was not
picked. I tested that the patch applies on top of linux-next + the latest
cros_ec cleanups (that includes a patch for this i2c driver and was taken
by Lee. So I think is safe for you take Doug's patch through your tree
since it seems to not cause any conflict with the mfd tree.
Or if you prefer, I can re-post that patch for 3.19.
Best regards,
Javier
[0]: https://lkml.org/lkml/2014/6/23/830
From: Wolfram Sang <hidden> Date: 2014-09-30 06:07:09
Doug posted a patch [0] to fix the issue you are reporting but it was not
picked. I tested that the patch applies on top of linux-next + the latest
cros_ec cleanups (that includes a patch for this i2c driver and was taken
by Lee. So I think is safe for you take Doug's patch through your tree
since it seems to not cause any conflict with the mfd tree.
On Fri, Sep 19, 2014 at 10:08:13AM +0200, Sjoerd Simons wrote:
To enable the cros_ec_keyb driver to be auto-loaded when build as
module add an of match table (and export it) to match the modalias
information passed on to userspace as the Cros EC MFD driver registers
the MFD subdevices with an of_compatibility string.
Signed-off-by: Sjoerd Simons <redacted>
Reviewed-by: Javier Martinez Canillas <redacted>
Applied, thank you.
quoted hunk
---
Changes in v2: Fixed some indentation issues
drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
1 file changed, 9 insertions(+)