[BUG] hid-multitouch ignores all event after recent patch in 3.17-rc1 to input_mt_sync_frame()

2 messages, 2 authors, 2014-08-27 · open the first message on its own page

[BUG] hid-multitouch ignores all event after recent patch in 3.17-rc1 to input_mt_sync_frame()

From: Reyad Attiyat <hidden>
Date: 2014-08-27 05:45:38

Hello Henrik Rydberg,

I noticed a recent patch to input-mt.c breaks hid-multitouch on my MS Surface:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/input/input-mt.c?id=f8ec894945e7d205ce62be59e55e72c4304e4739

This device uses a special quirk in the hid-multitouch driver to
ignore duplicate input events. This quirk uses the inline function
input_mt_is_used() to determine if an input frame is a duplicate. In
the patch you remove the line, mt->frame++, from the function
input_mt_sync_frame(). This causes the is_used function to return true
as the frame number never increases.

What would be the best way to solve this, is it ok to simply re add that line?

Thank You,
Reyad Attiyat

Re: [BUG] hid-multitouch ignores all event after recent patch in 3.17-rc1 to input_mt_sync_frame()

From: Henrik Rydberg <hidden>
Date: 2014-08-27 06:43:07

What would be the best way to solve this, is it ok to simply re add that line?
Not quite, but put an "else" in front and it is ok. A patch to that effect is
already on its way to Linus, so you will soon be able to cherry-pick it.

Thanks,
Henrik
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help