# \[PATCH\] HID: rmi: Protect PM-only functions by \#ifdef CONFIG\_PM - Subsystems: HID CORE LAYER, THE REST - Maintainers: Jiri Kosina, Benjamin Tissoires, Linus Torvalds - List: linux-input - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-input/2014/06/4271621/t ## \[PATCH\] HID: rmi: Protect PM-only functions by \#ifdef CONFIG\_PM - From: Geert Uytterhoeven \ - Date: 2014-06-11 19:03:25 - Message: https://ratatoskr.run/linux-input/2014/06/4271621.md ```text If CONFIG_PM=n: drivers/hid/hid-rmi.c:432: warning: ‘rmi_post_reset’ defined but not used drivers/hid/hid-rmi.c:437: warning: ‘rmi_post_resume’ defined but not used Signed-off-by: Geert Uytterhoeven --- drivers/hid/hid-rmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 2451c7e5febd..578bbe65902b 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -428,6 +428,7 @@ static int rmi_raw_event(struct hid_device *hdev, return 0; } +#ifdef CONFIG_PM static int rmi_post_reset(struct hid_device *hdev) { return rmi_set_mode(hdev, RMI_MODE_ATTN_REPORTS); @@ -437,6 +438,7 @@ static int rmi_post_resume(struct hid_device *hdev) { return rmi_set_mode(hdev, RMI_MODE_ATTN_REPORTS); } +#endif /* CONFIG_PM */ #define RMI4_MAX_PAGE 0xff #define RMI4_PAGE_SIZE 0x0100 -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ``` ## Re: \[PATCH\] HID: rmi: Protect PM-only functions by \#ifdef CONFIG\_PM - From: Jiri Kosina \ - Date: 2014-06-12 08:31:43 - Message: https://ratatoskr.run/linux-input/2014/06/4271983.md ```text On Wed, 11 Jun 2014, Geert Uytterhoeven wrote: > If CONFIG_PM=n: > > drivers/hid/hid-rmi.c:432: warning: ‘rmi_post_reset’ defined but not used > drivers/hid/hid-rmi.c:437: warning: ‘rmi_post_resume’ defined but not used > > Signed-off-by: Geert Uytterhoeven > --- > drivers/hid/hid-rmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c > index 2451c7e5febd..578bbe65902b 100644 > --- a/drivers/hid/hid-rmi.c > +++ b/drivers/hid/hid-rmi.c > @@ -428,6 +428,7 @@ static int rmi_raw_event(struct hid_device *hdev, > return 0; > } > > +#ifdef CONFIG_PM > static int rmi_post_reset(struct hid_device *hdev) > { > return rmi_set_mode(hdev, RMI_MODE_ATTN_REPORTS); > @@ -437,6 +438,7 @@ static int rmi_post_resume(struct hid_device *hdev) > { > return rmi_set_mode(hdev, RMI_MODE_ATTN_REPORTS); > } > +#endif /* CONFIG_PM */ > > #define RMI4_MAX_PAGE 0xff > #define RMI4_PAGE_SIZE 0x0100 Applied, thanks for spotting it. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ```