Re: [patch] Input: remove a duplicative NULL test

On Friday, February 21, 2014 6:15 PM, fugang.duan@freescale.com wrote:

From: Dan Carpenter <redacted>
Data: Friday, February 21, 2014 4:55 PM

quoted

To: Dmitry Torokhov
Cc: Paul Gortmaker; Jingoo Han; Duan Fugang-B38611; Benson Leung; Daniel Kurtz;
linux-input@vger.kernel.org; kernel-janitors@vger.kernel.org
Subject: [patch] Input: remove a duplicative NULL test

"pdata" is non-NULL here.  We verified that at the start of the function.

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c

b/drivers/input/touchscreen/atmel_mxt_ts.c
index a70400754e92..40abe90cc924 100644

--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c

@@ -1146,7 +1146,7 @@ static int mxt_probe(struct i2c_client *client,

		goto err_free_mem;
	}

-	data->is_tp = pdata && pdata->is_tp;
+	data->is_tp = pdata->is_tp;

	input_dev->name = (data->is_tp) ? "Atmel maXTouch Touchpad" :
					  "Atmel maXTouch Touchscreen";

Agree, it is redundant. And if you have free time, you can convert the driver to support devicetree.

Acked-by: Fugang Duan <redacted>

Reviewed-by: Jingoo Han <redacted>

Best regards,
Jingoo Han