# Re: \[PATCH 10/14\] HID: wiimote: replace hid\_output\_raw\_report with hid\_hw\_output\_report for output requests

- From: David Herrmann \<hidden\>
- Date: 2014-02-12 10:39:34 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2014/02/4198115
- Thread: https://ratatoskr.run/linux-input/2014/02/4196262/t.md

```text
Hi

On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires
[ref] wrote:
> For BT transport layer,
>   ret = hid_output_raw_report(A, B, C, HID_OUTPUT_REPORT);
> is equivalent to
>   ret = hid_hw_output_report(A, B, C);
>
> So use the new API where available

Reviewed-by: David Herrmann <redacted>

Thanks
David

>
> Signed-off-by: Benjamin Tissoires <redacted>
> ---
>  drivers/hid/hid-wiimote-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c
> index d7dc6c5b..d003914 100644
> --- a/drivers/hid/hid-wiimote-core.c
> +++ b/drivers/hid/hid-wiimote-core.c
> @@ -28,14 +28,14 @@ static int wiimote_hid_send(struct hid_device *hdev, __u8 *buffer,
>         __u8 *buf;
>         int ret;
>
> -       if (!hdev->hid_output_raw_report)
> +       if (!hdev->ll_driver->output_report)
>                 return -ENODEV;
>
>         buf = kmemdup(buffer, count, GFP_KERNEL);
>         if (!buf)
>                 return -ENOMEM;
>
> -       ret = hid_output_raw_report(hdev, buf, count, HID_OUTPUT_REPORT);
> +       ret = hid_hw_output_report(hdev, buf, count);
>
>         kfree(buf);
>         return ret;
> --
> 1.8.3.1
>
```
