Thread (4 messages) 4 messages, 3 authors, 2013-10-17

Re: [PATCH v2] drivers: input: mouse: Remove useless casting in cypress_ps2.c

From: Joe Perches <joe@perches.com>
Date: 2013-10-16 22:40:09
Also in: lkml

On Wed, 2013-10-16 at 19:31 -0300, Geyslan G. Bem wrote:
Get rid of unnecessary (void *) casting in 'cypress_init' function.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c
[]
quoted hunk ↗ jump to hunk
@@ -680,7 +680,7 @@ int cypress_init(struct psmouse *psmouse)
 	struct cytp_data *cytp;
 
 	cytp = (struct cytp_data *)kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
-	psmouse->private = (void *)cytp;
+	psmouse->private = cytp;
If you are going to remove useless casts, please
also remove the unnecessary kzalloc cast too.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help