[PATCH -next] Input: olpc_apsp - remove redundant dev_err call in olpc_apsp_probe()

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE4786d

2 messages, 2 authors, 2013-07-17 · open the first message on its own page

[PATCH -next] Input: olpc_apsp - remove redundant dev_err call in olpc_apsp_probe()

From: Wei Yongjun <hidden>
Date: 2013-07-17 05:31:05

From: Wei Yongjun <redacted>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/input/serio/olpc_apsp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/serio/olpc_apsp.c b/drivers/input/serio/olpc_apsp.c
index 818aa46..c96e3bd 100644
--- a/drivers/input/serio/olpc_apsp.c
+++ b/drivers/input/serio/olpc_apsp.c
@@ -187,10 +187,8 @@ static int olpc_apsp_probe(struct platform_device *pdev)
 		return -ENOENT;
 
 	priv->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(priv->base)) {
-		dev_err(&pdev->dev, "Failed to map WTM registers\n");
+	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
-	}
 
 	priv->irq = platform_get_irq(pdev, 0);
 	if (priv->irq < 0)

Re: [PATCH -next] Input: olpc_apsp - remove redundant dev_err call in olpc_apsp_probe()

From: Daniel Drake <hidden>
Date: 2013-07-17 13:00:10

On Tue, Jul 16, 2013 at 11:31 PM, Wei Yongjun [off-list ref] wrote:
From: Wei Yongjun <redacted>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <redacted>
Acked-by: Daniel Drake <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help