Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2013-07-07 19:15:27
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2013-07-03 · Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices · Dan Carpenter <hidden>
- 2013-07-03 · Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices · Ferruh Yigit <hidden>
- 2013-07-02 · re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices · Dan Carpenter <hidden>
On Fri, Jul 5, 2013 at 1:51 AM, Linux Kernel Mailing List [off-list ref] wrote:
quoted hunk
+++ b/drivers/input/touchscreen/cyttsp4_spi.c
+static int cyttsp_spi_xfer(struct device *dev, u8 *xfer_buf,
+ u8 op, u8 reg, u8 *buf, int length)
+{+ if (reg > 255)
As "reg" is "u8", this is never true: drivers/input/touchscreen/cyttsp4_spi.c: In function ‘cyttsp_spi_xfer’: drivers/input/touchscreen/cyttsp4_spi.c:66: warning: comparison is always false due to limited range of data type
+ wr_buf[0] = op + CY_SPI_A8_BIT; + else + wr_buf[0] = op;
Can the if-clause and the first branch just be removed, or is there a real bug
involved (e.g. wrong type for "reg")?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html