[PATCH] tsc40: remove wrong announcement of pressure support

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE5046d

2 messages, 2 authors, 2012-10-31 · open the first message on its own page

[PATCH] tsc40: remove wrong announcement of pressure support

From: Rolf Eike Beer <hidden>
Date: 2012-10-26 07:34:46

The tsc40 driver announces it supports the pressure event, but will never send
one. The announcement will cause tslib to wait for such events and sending all
touch events with a pressure of 0. Removing the announcement will make tslib
fall back to emulating the pressure on touch events so everything works as
expected.

Signed-off-by: Rolf Eike Beer <redacted>
Cc: stable@vger.kernel.org
---
 drivers/input/touchscreen/tsc40.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/input/touchscreen/tsc40.c b/drivers/input/touchscreen/tsc40.c
index 63209aa..eb96f16 100644
--- a/drivers/input/touchscreen/tsc40.c
+++ b/drivers/input/touchscreen/tsc40.c
@@ -107,7 +107,6 @@ static int tsc_connect(struct serio *serio, struct serio_driver *drv)
 	__set_bit(BTN_TOUCH, input_dev->keybit);
 	input_set_abs_params(ptsc->dev, ABS_X, 0, 0x3ff, 0, 0);
 	input_set_abs_params(ptsc->dev, ABS_Y, 0, 0x3ff, 0, 0);
-	input_set_abs_params(ptsc->dev, ABS_PRESSURE, 0, 0, 0, 0);
 
 	serio_set_drvdata(serio, ptsc);
 
-- 
1.7.11.5

Re: [PATCH] tsc40: remove wrong announcement of pressure support

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2012-10-31 06:41:12

On Fri, Oct 26, 2012 at 09:35:57AM +0200, Rolf Eike Beer wrote:
The tsc40 driver announces it supports the pressure event, but will never send
one. The announcement will cause tslib to wait for such events and sending all
touch events with a pressure of 0. Removing the announcement will make tslib
fall back to emulating the pressure on touch events so everything works as
expected.

Signed-off-by: Rolf Eike Beer <redacted>
Cc: stable@vger.kernel.org
Applied, thank you Rolf. 
quoted hunk
---
 drivers/input/touchscreen/tsc40.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/input/touchscreen/tsc40.c b/drivers/input/touchscreen/tsc40.c
index 63209aa..eb96f16 100644
--- a/drivers/input/touchscreen/tsc40.c
+++ b/drivers/input/touchscreen/tsc40.c
@@ -107,7 +107,6 @@ static int tsc_connect(struct serio *serio, struct serio_driver *drv)
 	__set_bit(BTN_TOUCH, input_dev->keybit);
 	input_set_abs_params(ptsc->dev, ABS_X, 0, 0x3ff, 0, 0);
 	input_set_abs_params(ptsc->dev, ABS_Y, 0, 0x3ff, 0, 0);
-	input_set_abs_params(ptsc->dev, ABS_PRESSURE, 0, 0, 0, 0);
 
 	serio_set_drvdata(serio, ptsc);
 
-- 
1.7.11.5


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help