# \[PATCH 1/1\] hid:Fix maxcontacts problem on GeneralTouch multi-touchscreen.

- Subsystems: HID CORE LAYER, THE REST
- Maintainers: Jiri Kosina, Benjamin Tissoires, Linus Torvalds
- List: linux-input
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-input/2012/10/3947562/t

## \[PATCH 1/1\] hid:Fix maxcontacts problem on GeneralTouch multi-touchscreen.

- From: Xianhan Yu \<hidden\>
- Date: 2012-10-29 07:03:18 
- Message: https://ratatoskr.run/linux-input/2012/10/3947562.md

```text
Fix maxcontacts problem for PWT GeneralTouch multi-touchscreen,modify driver for all GeneralTouch PWT touchscreen.

Signed-off-by: Xianhan Yu <redacted>
---
 drivers/hid/hid-multitouch.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 3eb02b9..7afeb77 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -210,8 +210,7 @@ static struct mt_class mt_classes[] = {
 	},
 	{ .name	= MT_CLS_GENERALTOUCH_PWT_TENFINGERS,
 		.quirks	= MT_QUIRK_NOT_SEEN_MEANS_UP |
-			MT_QUIRK_SLOT_IS_CONTACTNUMBER,
-		.maxcontacts = 10
+			MT_QUIRK_SLOT_IS_CONTACTNUMBER
 	},
 
 	{ .name = MT_CLS_FLATFROG,
-- 
1.7.9.5

```

## Re: \[PATCH 1/1\] hid:Fix maxcontacts problem on GeneralTouch multi-touchscreen.

- From: Jiri Kosina \<hidden\>
- Date: 2012-10-29 08:34:19 
- Message: https://ratatoskr.run/linux-input/2012/10/3947587.md

```text
On Mon, 29 Oct 2012, Xianhan Yu wrote:

> Fix maxcontacts problem for PWT GeneralTouch multi-touchscreen,modify 
> driver for all GeneralTouch PWT touchscreen.

Could you please provide some more verbose changelog, like what is the 
problem, why the original code was wrong and why the patch fixes the 
problem?

Thanks.

> 
> Signed-off-by: Xianhan Yu <redacted>
> ---
>  drivers/hid/hid-multitouch.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 3eb02b9..7afeb77 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -210,8 +210,7 @@ static struct mt_class mt_classes[] = {
>  	},
>  	{ .name	= MT_CLS_GENERALTOUCH_PWT_TENFINGERS,
>  		.quirks	= MT_QUIRK_NOT_SEEN_MEANS_UP |
> -			MT_QUIRK_SLOT_IS_CONTACTNUMBER,
> -		.maxcontacts = 10
> +			MT_QUIRK_SLOT_IS_CONTACTNUMBER
>  	},
>  
>  	{ .name = MT_CLS_FLATFROG,
> -- 
> 1.7.9.5
> 

-- 
Jiri Kosina
SUSE Labs
```
