Re: [PATCH] input: wrong irq requested in edt-ft5x06.c
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2012-09-19 16:58:30
Hi Stefano, On Wed, Sep 19, 2012 at 04:53:54PM +0200, Stefano Babic wrote:
The probe function checks for integrity the pdata->irq_pin, but then does not request this line for interrupt. For this reason, no interrupts are generated. Tested on a AM3517 board with EP0700M06
Why is your board code does not set client->irq properly? Thanks.
quoted hunk ↗ jump to hunk
Signed-off-by: Stefano Babic <redacted> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> CC: Simon Budig <redacted> CC: Guenter Roeck <linux@roeck-us.net> --- drivers/input/touchscreen/edt-ft5x06.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index b06a5e3..9608281 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c@@ -788,7 +788,8 @@ static int __devinit edt_ft5x06_ts_probe(struct i2c_client *client, input_set_drvdata(input, tsdata); i2c_set_clientdata(client, tsdata); - error = request_threaded_irq(client->irq, NULL, edt_ft5x06_ts_isr, + error = request_threaded_irq(gpio_to_irq(pdata->irq_pin), NULL, + edt_ft5x06_ts_isr, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, client->name, tsdata); if (error) {-- 1.7.9.5
-- Dmitry