[PATCH 1/2] HID: primax: Remove px_probe() and px_remove() functions

Subsystems: hid core layer, the rest

STALE5097d

5 messages, 3 authors, 2012-09-07 · open the first message on its own page

[PATCH 1/2] HID: primax: Remove px_probe() and px_remove() functions

From: Axel Lin <hidden>
Date: 2012-09-07 07:11:58

The px_probe() and px_remove() functions do not have any special initialization
and cleanup. Remove them and let HID core handle the default probe/remove
actions.

Signed-off-by: Axel Lin <redacted>
---
 drivers/hid/hid-primax.c |   25 -------------------------
 1 file changed, 25 deletions(-)
diff --git a/drivers/hid/hid-primax.c b/drivers/hid/hid-primax.c
index 4d3c60d..c15adb0 100644
--- a/drivers/hid/hid-primax.c
+++ b/drivers/hid/hid-primax.c
@@ -64,29 +64,6 @@ static int px_raw_event(struct hid_device *hid, struct hid_report *report,
 	return 0;
 }
 
-static int px_probe(struct hid_device *hid, const struct hid_device_id *id)
-{
-	int ret;
-
-	ret = hid_parse(hid);
-	if (ret) {
-		hid_err(hid, "parse failed\n");
-		goto fail;
-	}
-
-	ret = hid_hw_start(hid, HID_CONNECT_DEFAULT);
-	if (ret)
-		hid_err(hid, "hw start failed\n");
-
-fail:
-	return ret;
-}
-
-static void px_remove(struct hid_device *hid)
-{
-	hid_hw_stop(hid);
-}
-
 static const struct hid_device_id px_devices[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_PRIMAX, USB_DEVICE_ID_PRIMAX_KEYBOARD) },
 	{ }
@@ -97,8 +74,6 @@ static struct hid_driver px_driver = {
 	.name = "primax",
 	.id_table = px_devices,
 	.raw_event = px_raw_event,
-	.probe = px_probe,
-	.remove = px_remove,
 };
 
 static int __init px_init(void)
-- 
1.7.9.5


[PATCH 2/2] HID: waltop: Remove waltop_probe() and waltop_remove() functions

From: Axel Lin <hidden>
Date: 2012-09-07 07:13:30

The waltop_probe() and waltop_remove() functions do not have any special
initialization and cleanup. Remove them and let HID core handle the default
probe/remove actions.

Signed-off-by: Axel Lin <redacted>
---
 drivers/hid/hid-waltop.c |   29 -----------------------------
 1 file changed, 29 deletions(-)
diff --git a/drivers/hid/hid-waltop.c b/drivers/hid/hid-waltop.c
index 745e4e9..bb536ab 100644
--- a/drivers/hid/hid-waltop.c
+++ b/drivers/hid/hid-waltop.c
@@ -638,28 +638,6 @@ static __u8 sirius_battery_free_tablet_rdesc_fixed[] = {
 	0xC0                /*  End Collection                      */
 };
 
-static int waltop_probe(struct hid_device *hdev,
-			const struct hid_device_id *id)
-{
-	int ret;
-
-	ret = hid_parse(hdev);
-	if (ret) {
-		hid_err(hdev, "parse failed\n");
-		goto err;
-	}
-
-	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
-	if (ret) {
-		hid_err(hdev, "hw start failed\n");
-		goto err;
-	}
-
-	return 0;
-err:
-	return ret;
-}
-
 static __u8 *waltop_report_fixup(struct hid_device *hdev, __u8 *rdesc,
 		unsigned int *rsize)
 {
@@ -776,11 +754,6 @@ static int waltop_raw_event(struct hid_device *hdev, struct hid_report *report,
 	return 0;
 }
 
-static void waltop_remove(struct hid_device *hdev)
-{
-	hid_hw_stop(hdev);
-}
-
 static const struct hid_device_id waltop_devices[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_WALTOP,
 				USB_DEVICE_ID_WALTOP_SLIM_TABLET_5_8_INCH) },
@@ -803,10 +776,8 @@ MODULE_DEVICE_TABLE(hid, waltop_devices);
 static struct hid_driver waltop_driver = {
 	.name = "waltop",
 	.id_table = waltop_devices,
-	.probe = waltop_probe,
 	.report_fixup = waltop_report_fixup,
 	.raw_event = waltop_raw_event,
-	.remove = waltop_remove,
 };
 
 static int __init waltop_init(void)
-- 
1.7.9.5


Re: [PATCH 2/2] HID: waltop: Remove waltop_probe() and waltop_remove() functions

From: Nikolai Kondrashov <hidden>
Date: 2012-09-07 07:29:07

On Fri, Sep 7, 2012 at 10:13 AM, Axel Lin [off-list ref] wrote:
The waltop_probe() and waltop_remove() functions do not have any special
initialization and cleanup. Remove them and let HID core handle the default
probe/remove actions.
Signed-off-by: Nikolai Kondrashov <redacted>

Thanks, Axel.

Sincerely,
Nick

Re: [PATCH 2/2] HID: waltop: Remove waltop_probe() and waltop_remove() functions

From: Nikolai Kondrashov <hidden>
Date: 2012-09-07 08:12:36

On Fri, Sep 7, 2012 at 10:29 AM, Nikolai Kondrashov [off-list ref] wrote:
Signed-off-by: Nikolai Kondrashov <redacted>
Sorry, it should be

Acked-by: Nikolai Kondrashov <redacted>

instead.

Sincerely,
Nick

Re: [PATCH 2/2] HID: waltop: Remove waltop_probe() and waltop_remove() functions

From: Jiri Kosina <hidden>
Date: 2012-09-07 12:55:04

On Fri, 7 Sep 2012, Nikolai Kondrashov wrote:
quoted
Signed-off-by: Nikolai Kondrashov <redacted>
Sorry, it should be

Acked-by: Nikolai Kondrashov <redacted>
Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help