# \[PATCH 2/2\] input: samsung-keypad: Use of\_get\_child\_count() helper - From: Tobias Klauser \ - Date: 2012-08-21 10:50:09 - List: linux-input - Page: https://ratatoskr.run/linux-input/2012/08/8920061 - Thread: https://ratatoskr.run/linux-input/2012/08/8920061/t.md ```text Use of_get_child_count() instead of custom implementation. Signed-off-by: Tobias Klauser --- drivers/input/keyboard/samsung-keypad.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c index e2f31c8..277e26d 100644 --- a/drivers/input/keyboard/samsung-keypad.c +++ b/drivers/input/keyboard/samsung-keypad.c @@ -256,7 +256,7 @@ static struct samsung_keypad_platdata *samsung_keypad_parse_dt( struct matrix_keymap_data *keymap_data; uint32_t *keymap, num_rows = 0, num_cols = 0; struct device_node *np = dev->of_node, *key_np; - unsigned int key_count = 0; + unsigned int key_count; pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) { @@ -280,9 +280,7 @@ static struct samsung_keypad_platdata *samsung_keypad_parse_dt( } pdata->keymap_data = keymap_data; - for_each_child_of_node(np, key_np) - key_count++; - + key_count = of_get_child_count(np); keymap_data->keymap_size = key_count; keymap = devm_kzalloc(dev, sizeof(uint32_t) * key_count, GFP_KERNEL); if (!keymap) { -- 1.7.5.4 ```