re: Input: eeti_ts: pass gpio value instead of IRQ

From: Dan Carpenter <hidden>
Date: 2012-08-10 12:25:40

Hello Arnd Bergmann,

This is a semi-automatic email about new static checker warnings.

The patch 4eef6cbfcc03: "Input: eeti_ts: pass gpio value instead of 
IRQ" from Apr 30, 2012, leads to the following Smatch complaint:

drivers/input/touchscreen/eeti_ts.c:209 eeti_ts_probe()
	 warn: variable dereferenced before check 'pdata' (see line 202)

drivers/input/touchscreen/eeti_ts.c
   201		priv->input = input;
   202		priv->irq_gpio = pdata->irq_gpio;
                                 ^^^^^^^^^^^^^^^
   203		priv->irq = gpio_to_irq(pdata->irq_gpio);
                                        ^^^^^^^^^^^^^^^
   204	
   205		err = gpio_request_one(pdata->irq_gpio, GPIOF_IN, client->name);
                                       ^^^^^^^^^^^^^^^
New dereferences.

   206		if (err < 0)
   207			goto err1;
   208	
   209		if (pdata)
                    ^^^^^
Old check.

   210			priv->irq_active_high = pdata->irq_active_high;
   211	

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help