# Re: \[PATCH v4\] Input: synaptics - handle out of bounds values from the hardware

- From: Seth Forshee \<hidden\>
- Date: 2012-07-25 13:47:21 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2012/07/8919972
- Thread: https://ratatoskr.run/linux-input/2012/06/8919801/t.md

```text
On Wed, Jul 25, 2012 at 10:50:15AM +0800, Daniel Kurtz wrote:
> > +       /* Convert wrap-around values to negative */
> > +       if (hw->x > X_MAX_POSITIVE)
> > +               hw->x = hw->x - (1 << ABS_POS_BITS);
> 
> Hi Seth,
> 
> Perhaps:
> hw->x -= (1 << ABS_POS_BITS);

It makes no difference to me, either way it works the same. I don't
think I'll send another patch just to change this though, unless Dmitry
asks for it :)

> Either way, it looks good, thanks!
> 
> Reviewed-by: Daniel Kurtz <redacted>

Thanks!

Seth
```
