[PATCH] gpio_keys: fix struct device declared inside parameter list

Subsystems: the rest

STALE5297d

3 messages, 2 authors, 2012-02-03 · open the first message on its own page

[PATCH] gpio_keys: fix struct device declared inside parameter list

From: Heiko Stübner <heiko@sntech.de>
Date: 2012-01-12 09:11:38

A struct device parameter is used in the enable and disable callbacks to
distinguish between different gpio_keys devices.

Platforms that don't use these callbacks may not include struct device
at all, as seen on arch/arm/mach-s3c2410/mach-n30.c

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 include/linux/gpio_keys.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/gpio_keys.h b/include/linux/gpio_keys.h
index b5ca4b2..004ff33 100644
--- a/include/linux/gpio_keys.h
+++ b/include/linux/gpio_keys.h
@@ -1,6 +1,8 @@
 #ifndef _GPIO_KEYS_H
 #define _GPIO_KEYS_H
 
+struct device;
+
 struct gpio_keys_button {
 	/* Configuration parameters */
 	unsigned int code;	/* input event code (KEY_*, SW_*) */
-- 
1.7.5.4

Re: [PATCH] gpio_keys: fix struct device declared inside parameter list

From: Heiko Stübner <heiko@sntech.de>
Date: 2012-01-31 21:27:58

Am Donnerstag 12 Januar 2012, 10:11:31 schrieb Heiko Stübner:
A struct device parameter is used in the enable and disable callbacks to
distinguish between different gpio_keys devices.

Platforms that don't use these callbacks may not include struct device
at all, as seen on arch/arm/mach-s3c2410/mach-n30.c

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
ping?

Thanks
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gpio_keys: fix struct device declared inside parameter list

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2012-02-03 08:37:06

On Tue, Jan 31, 2012 at 10:27:55PM +0100, Heiko Stübner wrote:
Am Donnerstag 12 Januar 2012, 10:11:31 schrieb Heiko Stübner:
quoted
A struct device parameter is used in the enable and disable callbacks to
distinguish between different gpio_keys devices.

Platforms that don't use these callbacks may not include struct device
at all, as seen on arch/arm/mach-s3c2410/mach-n30.c

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
ping?
Applied, thank you Heiko.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help