[PATCH] Set buttonpad property bit on bcm5974 devices.

Subsystems: apple bcm5974 multitouch driver, input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE5335d

2 messages, 2 authors, 2012-01-09 · open the first message on its own page

[PATCH] Set buttonpad property bit on bcm5974 devices.

From: Jussi Pakkanen <hidden>
Date: 2012-01-09 16:33:48

---
 drivers/input/mouse/bcm5974.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 5ec617e..7c69d9e 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c

@@ -876,6 +876,7 @@ static int bcm5974_probe(struct usb_interface *iface,
 
 	input_dev->name = "bcm5974";
 	input_dev->phys = dev->phys;
+	__set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit); 
 	usb_to_input_id(dev->udev, &input_dev->id);
 	/* report driver capabilities via the version field */
 	input_dev->id.version = cfg->caps;

-- 
1.7.5.4

Re: [PATCH] Set buttonpad property bit on bcm5974 devices.

From: Henrik Rydberg <hidden>
Date: 2012-01-09 17:08:38

Hi Jussi,

quoted hunk

diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 5ec617e..7c69d9e 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c

@@ -876,6 +876,7 @@ static int bcm5974_probe(struct usb_interface *iface,
 
 	input_dev->name = "bcm5974";
 	input_dev->phys = dev->phys;
+	__set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit); 
 	usb_to_input_id(dev->udev, &input_dev->id);
 	/* report driver capabilities via the version field */
 	input_dev->id.version = cfg->caps;

Only macbooks from 2010 and later have the integrated touchpad, so
this has clearly not been broadly tested. Please use the
HAS_INTEGRATED_BUTTON property to steer the logic right.

Thanks,
Henrik

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help