# Re: \[PATCH v2\] Touchscreen driver for FT5x06 based EDT displays

- From: agust@denx.de
- Date: 2011-12-15 12:17:45 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2011/12/8918554
- Thread: https://ratatoskr.run/linux-input/2011/09/8917849/t.md

```text
Hi Simon,

Simon Budig [ref] wrote:
...
> On 12/02/2011 02:51 PM, Anatolij Gustschin wrote:
>> there is a number of issues with this patch. Please check it
>> using 'scripts/checkpatch.pl' and fix them before posting next
>> patch version. Thanks! Please see a comment below.
>
> Ok, There are a lot of warnings/errors regarding my use of spaces for
> alignment of multi-line function calls.
>
> (i.e. use tabs for the logical indentation level plus spaces to align
> e.g. function arguments behind the opening parenthesis)
>
> <tab><tab>function (argument1,
> <tab><tab>          argument2);
>
> This has the advantage of not breaking alignment when changing tab
> width. Is this something acceptable in the kernel? It seems CodingStyle
> is open to interpretation there, not sure if the conding style is open
> for discussion though...  :)
>
> Or should I just globally replace 8 subsequent spaces with a tab?

My understanding is that CodingStyle insists on tabs for
indentation and tabs are always 8 characters wide. Additional
indentation for alignment of function arguments is done by
spaces, i.e.:

<tab>function(arg1,
<tab><tab>    arg2);

>> passing platform data for specifying reset_pin should be optional,
>> I think. There are hardware configurations without wired gpio for
>> /RST controlling, /RST is controlled by HW-circuitry. The driver
>> should be usable with such configurations, too. Can you please
>> change the driver so that controlling reset pin becomes optional?
>
> Will do.

Thanks,

Anatolij


```
