# Re: \[PATCH\] Input: atmel\_mxt\_ts - Use snprintf for sysfs attribute show method

- From: Nick Dyer \<hidden\>
- Date: 2011-10-06 10:08:35 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2011/10/3771929
- Thread: https://ratatoskr.run/linux-input/2011/09/3764049/t.md

```text
Hi Daniel-

Just to introduce myself, I'm working for Atmel in UK on the atmel_mxt_ts driver.

Daniel Kurtz wrote:
> Sysfs attribute show methods are always passed a buffer of length
> PAGE_SIZE.  To keep from overwriting this buffer and causing havoc,
> use snprintf() to guarantee we never write more than the buffer can
> hold.
>
> In addition, at least for my touchscreen, the number and size of
> objects was far too big to fit in a single 4K page.  Therefore, this
> patch also trims some redundant framing text to leave more room for
> actual data.

Yes, I'd noticed this problem as well. I was planning to address it by splitting up the file, but your patch looks like a good solution for now.

I've tested it successfully on several chips.

Acked-by: Nick Dyer <redacted>

-- 
Nick Dyer
Software Engineer, ITDev  Ltd

Hardware and Software Development Consultancy

Email:   nick.dyer@itdev.co.uk
Website: http://www.itdev.co.uk
```
